vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

hive-forge: paginate no-reviewer comment fetch (argus nit on #507)

Browse source
This commit is contained in:
damocles 2026-05-27 10:29:42 +02:00 • committed by Mara
commit 8f4cb3ed29
1 changed files with 10 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

18
hive-forge/src/verbs/lint.rs
View file

@ -173,14 +173,16 @@ fn run_no_reviewer(client: &Client, args: NoReviewerArgs) -> Result<()> {
if body.contains(&needle) {
continue;
}
let comments =
client.get_json(&format!("/repos/{repo}/issues/{number}/comments?limit=50"))?;
let mentioned = comments.as_array().is_some_and(|a| {
a.iter().any(|c| {
c.get("body")
.and_then(Value::as_str)
.is_some_and(|body| body.contains(&needle))
})
// Paginate so PRs with >50 comments don't yield false positives
// (argus nit on #507). Same 1000-comment ceiling as elsewhere.
let comments = client.get_json_all(
&format!("/repos/{repo}/issues/{number}/comments?limit={PAGE_LIMIT}"),
MAX_PAGES,
)?;
let mentioned = comments.iter().any(|c| {
c.get("body")
.and_then(Value::as_str)
.is_some_and(|body| body.contains(&needle))
});
if !mentioned {
missing.push(trim_item(pr));