Watch
0
0
Fork
You've already forked hyperhive
0

swarm-bao-agent-pki: decide openbao's restart on the shared locale-independent compare

`swarm-bao-agent-pki` carried its own copy of the mtime-vs-start compare,
with the same `stat -c %.6Y | tr -d .` read: on a comma-locale host the
`-le` errored and, under `seal = "pkcs11"`, openbao was restarted on
every run of the unit.

The compare moves out of `refresh_unit` into `written_after_start`
(0 newer, 1 not newer, 2 unreadable and logged at `err`), and both
`refresh_unit` and the agent-pki unit call it. The agent-pki unit cannot
call `refresh_unit` itself: it restarts with `restart`, not
`try-restart`, runs a fail-closed check of the bundle between the
compare and the restart, and under shamir prints the step instead of
restarting. It acts only on 0, so an unreadable time skips the restart
as `refresh_unit` does.

`script-test-refresh-consumer` covers the three return codes in the
agent-pki call shape; `module-eval-bao-basics` asserts both seal arms
decide on that call and that no `%.6Y` read is left in the unit.

Refs #5230
This commit is contained in:
atlas 2026-10-13 16:00:37 +02:00 • committed by mara
commit 8d554477ca
5 changed files with 67 additions and 24 deletions

View file

@ -1,7 +1,7 @@
# `checks.script-test-refresh-consumer` — runs ../host-modules/lib/refresh-consumer.nix's
# `refresh_unit` and `refresh_consumer` against a stub `systemctl`, under a
# locale whose decimal separator is a comma. The cases are in
# ./refresh-consumer.sh.
# `written_after_start`, `refresh_unit` and `refresh_consumer` against a stub
# `systemctl`, under a locale whose decimal separator is a comma. The cases
# are in ./refresh-consumer.sh.
#
# What runs is the rendered helper, sourced as its callers' scripts include it.
{