vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

hive-runtime: kill an ACP agent's whole process group, not just its pid

Browse source 
The ACP agent was spawned with only `kill_on_drop`, which SIGKILLs the
agent's own pid. Commands the agent had started (a `nix build`, a test
run) were reparented and kept running after the agent was killed: when a
subagent run ends after `interrupt`, when an agent ignores
`session/cancel` past the grace, and when the harness drops the runtime.

The agent now leads its own process group (`process_group(0)`), and
dropping its `Connection` SIGKILLs that group. The soft path is unchanged:
`interrupt` / `Canceller::cancel` still sends `session/cancel`.

Refs #4999. The claude half needs hive-claude 0.1.3, which is not on
crates.io yet.
This commit is contained in:
atlas 2026-10-09 23:57:07 +02:00
commit 8d206f124f
6 changed files with 149 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

1
hive-runtime/Cargo.toml
View file

@ -9,6 +9,7 @@ workspace = true
[dependencies]
hive-claude.workspace = true
libc.workspace = true
serde.workspace = true
serde_json.workspace = true
# The ACP agent's provider key, read under the agent's own certificate