vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(#2772): is_settled distinguishes "not finished" from "no such node"

Browse source 
Returning `false` for an unknown id gave the same answer as a node that is
merely still running, so a caller polling a stale id would wait forever for
a state that can never arrive. `Option<bool>` makes the two cases separate,
matching `node()`'s convention that `None` means the id isn't in the graph.
This commit is contained in:
atlas 2026-07-27 20:16:28 +02:00 • committed by mara
commit 8c5de704be
2 changed files with 25 additions and 13 deletions
Download patch file Download diff file Expand all files Collapse all files

6
hive-c0re/src/job_queue/mod.rs
View file

@ -480,7 +480,7 @@ impl JobQueue {
inner
.containers()
.into_iter()
.filter(|&c| !inner.sched.graph().is_settled(c))
.filter(|&c| inner.sched.graph().is_settled(c) == Some(false))
.count()
}
}
@ -652,7 +652,7 @@ impl QueueInner {
if !any_unsettled {
return None;
}
let is_terminal = self.sched.graph().is_settled(container);
let is_terminal = self.sched.graph().is_settled(container) == Some(true);
Some(DagView {
id: container.get(),
source: meta.source,
@ -695,7 +695,7 @@ impl QueueInner {
let mut live: Vec<NodeId> = Vec::new();
let mut terminal: Vec<(NodeId, i64)> = Vec::new();
for c in self.containers() {
if self.sched.graph().is_settled(c) {
if self.sched.graph().is_settled(c) == Some(true) {
terminal.push((c, self.dag_finished_at(c)));
} else {
live.push(c);