hive-c0re: a refused rev is an error log + Grafana alert, not a PR comment
A deploy request whose rev hive-c0re refuses (fetch failed, or the rev does not descend from applied/main) no longer tries to comment on the PR that merged it. Off the forge host that attempt always failed with "forge core token absent". The refusal now logs at ERROR, message unchanged, and the new `hh-config-rev-refused` Grafana rule fires on it. Deleted with the posting: actions::post_rev_deploy_failure_to_pr, the whole forge/pr_comment.rs (config_repo, merged_pr_for_commit, post_pr_comment), and ReaderToken::value, whose only caller was merged_pr_for_commit. Refs #4851
This commit is contained in:
parent
3d81266483
commit
8c222f8910
9 changed files with 27 additions and 106 deletions
|
|
@ -1003,6 +1003,20 @@ in
|
|||
for = "15m";
|
||||
summary = "swarm-controller has failed the agent credential renewal pass on consecutive ticks";
|
||||
})
|
||||
# Logged once per refused deploy request, by
|
||||
# `apply_rev` in hive-c0re's swarm_status.rs; the window is
|
||||
# how long the rule stays firing after it. Host journal
|
||||
# records carry the tracing fields as `F_<NAME>` and no
|
||||
# `hive` attribute, so the machine is `_HOSTNAME`. The unit
|
||||
# filter keeps out agent logs that quote the message.
|
||||
(logCountRule {
|
||||
uid = "hh-config-rev-refused";
|
||||
title = "config rev refused";
|
||||
windowSeconds = 900;
|
||||
expr = ''_time:15m _SYSTEMD_UNIT:="hive-c0re.service" _msg:"swarm events: rev not applied; nothing queued" | stats by (_HOSTNAME, F_AGENT, F_REV) count() as refusals'';
|
||||
for = "0s";
|
||||
summary = "{{ $labels._HOSTNAME }} refused to deploy merged config commit {{ $labels.F_REV }} of agent {{ $labels.F_AGENT }}; the reason is the `F_ERROR` field of the hive-c0re log line";
|
||||
})
|
||||
]
|
||||
# One rule per declared hive rather than one grouped by
|
||||
# `hive`, so a hive that sends nothing at all still has
|
||||
|
|
|
|||
Loading…
Reference in a new issue