vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

credential units: restart consumers on a changed credential; fix the ordering claim

Browse source 
The previous commit's comments said a unit in auto-restart keeps its
start job, so anything ordered after it waits for the whole 24h retry
window. That is wrong under the default RestartMode=normal: each failed
attempt passes through `failed`, which ends that start job. `After=`
dependents proceed after one attempt, `Requires=` dependents fail with
`dependency`, and the retries continue as fresh start jobs. The
2026-09-24 journal shows it with the already-2880 swarm-services-cert:
nginx got "Dependency failed" 1ms after the first failure, and
switch-to-configuration exited before the first restart was scheduled.
The comments in lib/store-retry.nix, glue-matrix-bao-token.nix,
glue-queue-agent-credential.nix, swarm-otel.nix and swarm-grafana.nix
now say that, and so does docs/swarm/credentials.md.

Because dependents start after one attempt, a consumer that loads its
credential at start never sees a value a later attempt lands, or a
rotated one. nix/host-modules/lib/refresh-consumer.nix adds
`secret_differs` and `refresh_consumer`, and the four fetch units whose
consumers take a start-time copy call them after the write, only when
the value changed:

- swarm-bao-matrix-token -> tuwunel.service in hive-matrix
- swarm-bao-otel-oidc -> opentelemetry-collector.service in swarm-otel
- swarm-bao-grafana-oidc -> grafana.service in the grafana container
- swarm-bao-forwarder-oidc -> opentelemetry-collector.service in swarm-bao

A running consumer is try-restarted, a failed one is reset and started,
all with --no-block. Inline in the fetch script rather than a
PathChanged path unit because the fetch script is the only writer and
already knows whether the value changed, and it is the same shape as
this PR's nginx hook and swarm-bao-nats-tls's restart of nats.

module-eval-bao-grants gains one case per consumer.

Refs #4662
This commit is contained in:
atlas 2026-09-30 00:00:28 +02:00 • committed by mara
commit 7eb966fe2b
9 changed files with 178 additions and 22 deletions
Download patch file Download diff file Expand all files Collapse all files

45
nix/module-eval/bao-grants.nix
View file

@ -1563,6 +1563,49 @@ let
&& lib.hasInfix ''"token_policies":["swarm-operator-viewer"]'' s
&& lib.hasInfix ''"allowed_redirect_uris":["https://bao-ui.t.local/ui/vault/auth/oidc/oidc/callback"]'' s;
}
];
]
# A consumer that loads its credential at start never sees one a later
# attempt lands, so the fetch that lands it restarts that consumer — only
# on a changed value, so a routine re-fetch leaves it running.
++
map
(
{
fetch,
machine,
consumer,
}:
{
name = "${fetch} restarts ${consumer} in ${machine} when the value it fetched changed";
ok =
let
s = baoGrantWithConsumers.systemd.services.${fetch}.script;
in
lib.hasInfix "secret_differs " s
&& lib.hasInfix "refresh_consumer ${lib.escapeShellArg machine} ${consumer}" s;
}
)
[
{
fetch = "swarm-bao-matrix-token";
machine = "hive-matrix";
consumer = "tuwunel.service";
}
{
fetch = "swarm-bao-otel-oidc";
machine = baoGrantWithConsumers.services.hyperhive.swarm.otel.machine;
consumer = "opentelemetry-collector.service";
}
{
fetch = "swarm-bao-grafana-oidc";
machine = baoGrantWithConsumers.services.hyperhive.swarm.grafana.machine;
consumer = "grafana.service";
}
{
fetch = "swarm-bao-forwarder-oidc";
machine = baoGrantWithConsumers.services.hyperhive.swarm.bao.machine;
consumer = "opentelemetry-collector.service";
}
];
in
runGroup "bao-grants" cases