vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

review-classifier: check that a commit message's claimed changes are in the diff

Browse source 
message-claims-match-diff is the reverse of one-purpose: a README, doc
page, test or rename the message names must be in the diff. The rules
file then holds the ten-rule cap, so the new-rule merge test appends to
the file minus its last entry and no longer depends on how many rules the
file holds.
This commit is contained in:
argus 2026-11-01 12:05:01 +01:00 • committed by mara
commit 7aa8441aa1
2 changed files with 19 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

1
swarm-controller/src/review_classifier.rs
View file

@ -1336,6 +1336,7 @@ classifications:
"tests-with-behaviour",
"docs-updated",
"one-purpose",
"message-claims-match-diff",
]
);
}

13
swarm-controller/src/review_classifier/open_pr.rs
View file

@ -537,22 +537,27 @@ mod tests {
#[test]
fn a_new_rule_leaves_every_existing_entry_as_it_was_written() {
let [yml, _] = RULES_PATHS;
let before = parse_rules(yml, OWN.as_bytes()).expect("this repo's rules parse");
// This repo's file without its last entry: the file may already hold
// the cap, and the property under test is how a new entry is appended,
// not how many entries the file has today.
let last = OWN.rfind("\n - name:").expect("a last entry") + 1;
let own = &OWN[..last];
let before = parse_rules(yml, own.as_bytes()).expect("this repo's rules parse");
let new = rule(
"no-todo",
"The diff adds a TODO or FIXME comment without a tracker reference next to it, \
which leaves the follow-up with nobody to own it.",
);
let merged = merge(Some(&file(yml, OWN)), vec![new.clone()]).expect("merges");
let merged = merge(Some(&file(yml, own)), vec![new.clone()]).expect("merges");
let text = String::from_utf8(merged.content).expect("utf-8");
assert!(text.starts_with(OWN), "{text}");
assert!(text.starts_with(own), "{text}");
assert_eq!(merged.sha.as_deref(), Some("b1"));
assert_eq!(merged.message, "review classifier: add no-todo");
let after = parse_rules(yml, text.as_bytes()).expect("parses");
assert_eq!(after, [before, vec![new.clone()]].concat());
assert!(text.lines().all(|l| l.len() <= YAML_WIDTH), "{text}");
let unterminated = OWN.trim_end();
let unterminated = own.trim_end();
let merged = merge(Some(&file(yml, unterminated)), vec![new]).expect("merges");
let text = String::from_utf8(merged.content).expect("utf-8");
assert!(