vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

type Approval.agent as Ident

Browse source
This commit is contained in:
damocles 2026-07-22 19:38:23 +02:00 • committed by mara
commit 76647415af
10 changed files with 71 additions and 53 deletions
Download patch file Download diff file Expand all files Collapse all files

9
hive-c0re/src/dashboard/approvals.rs
View file

@ -66,12 +66,7 @@ pub(super) fn gc_orphans(coord: &Coordinator, approvals: Vec<Approval>) -> Vec<A
) {
return true;
}
let Ok(agent) = hive_types::Ident::parse(&a.agent) else {
let _ = coord.approvals.mark_failed(a.id, "invalid agent name");
tracing::warn!(id = a.id, agent = %a.agent, "auto-failed approval with invalid agent name");
return false;
};
if Coordinator::agent_proposed_dir(&agent).exists() {
if Coordinator::agent_proposed_dir(&a.agent).exists() {
true
} else {
let note = "agent state dir missing";
@ -83,7 +78,7 @@ pub(super) fn gc_orphans(coord: &Coordinator, approvals: Vec<Approval>) -> Vec<A
.map(|s| s[..s.len().min(12)].to_owned());
coord.emit_approval_resolved(crate::coordinator::ApprovalResolved {
id: a.id,
agent: &a.agent,
agent: a.agent.as_str(),
approval_kind: a.kind.as_str(),
sha_short,
status: "failed",

12
hive-c0re/src/dashboard/state_snapshot.rs
View file

@ -552,7 +552,7 @@ fn history_view(a: Approval) -> ApprovalHistoryView {
let kind = a.kind.as_str();
ApprovalHistoryView {
id: a.id,
agent: a.agent,
agent: a.agent.to_string(),
kind,
sha_short,
status,
@ -567,7 +567,7 @@ fn build_approval_views(approvals: Vec<Approval>) -> Vec<ApprovalView> {
out.push(match a.kind {
hive_sh4re::ApprovalKind::Spawn => ApprovalView {
id: a.id,
agent: a.agent,
agent: a.agent.to_string(),
kind: "spawn",
sha_short: None,
description: a.description,
@ -577,7 +577,7 @@ fn build_approval_views(approvals: Vec<Approval>) -> Vec<ApprovalView> {
},
hive_sh4re::ApprovalKind::InitConfig => ApprovalView {
id: a.id,
agent: a.agent,
agent: a.agent.to_string(),
kind: "init_config",
sha_short: None,
description: a.description,
@ -587,7 +587,7 @@ fn build_approval_views(approvals: Vec<Approval>) -> Vec<ApprovalView> {
},
hive_sh4re::ApprovalKind::UpdateMetaInputs => ApprovalView {
id: a.id,
agent: a.agent,
agent: a.agent.to_string(),
kind: "update_meta_inputs",
sha_short: None,
description: a.description,
@ -597,7 +597,7 @@ fn build_approval_views(approvals: Vec<Approval>) -> Vec<ApprovalView> {
},
hive_sh4re::ApprovalKind::SchedulePrompt => ApprovalView {
id: a.id,
agent: a.agent,
agent: a.agent.to_string(),
kind: "schedule_prompt",
sha_short: None,
description: a.description,
@ -618,7 +618,7 @@ fn build_approval_views(approvals: Vec<Approval>) -> Vec<ApprovalView> {
let pr_number = a.commit_ref.parse::<u64>().ok();
ApprovalView {
id: a.id,
agent: a.agent,
agent: a.agent.to_string(),
kind: "merge_config_pr",
sha_short: sha,
description: a.description,