vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

nix(c0re): trim the network-isolation narrative from the forge/matrix URL comments

Browse source 
Per mara's review of #1718: the HIVE_FORGE_URL / HIVE_MATRIX_URL comments
carried "network isolation is now unconditional / shared-netns removed"
backstory that doesn't belong on those keys. Trimmed to describe just the
value (the gateway vhost) + the gatewayHost null-guard. The
isolation-removal narrative stays where it's on-topic — the network
module's own deprecated-option descriptions and warning text.
This commit is contained in:
atlas 2026-06-17 16:58:20 +02:00
commit 75dbcc2aa2
1 changed files with 8 additions and 14 deletions
Download patch file Download diff file Expand all files Collapse all files

22
nix/modules/hive-c0re.nix
View file

@ -750,24 +750,18 @@ in
HYPERHIVE_SWARM_NAME = config.services.hyperhive.swarmName; HYPERHIVE_SWARM_NAME = config.services.hyperhive.swarmName;
} }
// lib.optionalAttrs config.services.hyperhive.forge.enable { // lib.optionalAttrs config.services.hyperhive.forge.enable {
# In-cluster forge URL. Network isolation is unconditional (the # In-cluster forge URL — the gateway vhost (`forge.<domain>`), which
# shared-netns mode was removed), so agents always resolve # nginx proxies to forgejo. Set directly: this env only exists when
# `forge.<domain>` via the bridge dnsmasq and reach nginx on port 80 # hyperhive is enabled. See `docs/gateway.md::HIVE_FORGE_URL`.
# (nginx proxies to forgejo as it does for the operator) — there is
# no host-loopback path. This env is only set when hyperhive is
# enabled, so the gateway URL is unconditionally correct here.
# See `docs/gateway.md::HIVE_FORGE_URL`.
HIVE_FORGE_URL = "http://${config.services.hyperhive.forge.domain}"; HIVE_FORGE_URL = "http://${config.services.hyperhive.forge.domain}";
} }
// lib.optionalAttrs config.services.hyperhive.matrix.enable { // lib.optionalAttrs config.services.hyperhive.matrix.enable {
# In-cluster matrix homeserver URL for each agent's # In-cluster matrix homeserver URL for each agent's
# hive-matrix-daemon — the gateway vhost (`matrix.<domain>`) on plain # hive-matrix-daemon — the gateway vhost (`matrix.<domain>`). The
# http:80. Network isolation is unconditional, so there is no # gatewayHost null-guard falls back to loopback so a domain-less
# host-loopback path; the only remaining conditional is the # config still evals. Forwarded to agents by meta.rs alongside
# gatewayHost null-guard, which falls back to loopback so a # HIVE_FORGE_URL; shares the same env-forwarding ordering caveat
# domain-less config still evals. Forwarded to agents by meta.rs # (value baked at config-generation time).
# alongside HIVE_FORGE_URL; shares the same env-forwarding ordering
# caveat (value baked at config-generation time).
HIVE_MATRIX_URL = HIVE_MATRIX_URL =
if config.services.hyperhive.matrix.gatewayHost != null then if config.services.hyperhive.matrix.gatewayHost != null then
"http://${config.services.hyperhive.matrix.gatewayHost}" "http://${config.services.hyperhive.matrix.gatewayHost}"