vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

fix(#2290): register_agent in handle_spawn (event-driven, replaces stale spawn_poll comment)

Browse source
This commit is contained in:
atlas 2026-07-09 01:05:53 +02:00
commit 66c6828359
1 changed files with 9 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

13
hive-c0re/src/server.rs
View file

@ -205,14 +205,18 @@ async fn handle_spawn(coord: &Arc<Coordinator>, name: &str) -> Result<HostRespon
let agent_dir = Coordinator::agent_dir(name); let agent_dir = Coordinator::agent_dir(name);
let hive = coord.hive_env(); let hive = coord.hive_env();
let paths = Coordinator::agent_paths(name, agent_dir); let paths = Coordinator::agent_paths(name, agent_dir);
// lifecycle::spawn creates the runtime dir internally before start, so // lifecycle::spawn creates the runtime dir internally before start.
// no manual ensure_agent_runtime_dir here. MCP listener registration is // MCP listener registration is event-driven: bind immediately on
// handled by mcp_sockets::spawn_poll on its first post-start tick. // success so the harness can connect on its first turn without
// waiting for any poll interval.
match lifecycle::spawn(name, &hive, &paths).await { match lifecycle::spawn(name, &hive, &paths).await {
Ok(()) => { Ok(()) => {
if let Err(e) = coord.power.set(name, crate::power::Wanted::Up) { if let Err(e) = coord.power.set(name, crate::power::Wanted::Up) {
tracing::warn!(%name, error = ?e, "agent_power: set wanted=up failed"); tracing::warn!(%name, error = ?e, "agent_power: set wanted=up failed");
} }
// Bind the MCP listener now that the container is starting up.
// The harness connects to this socket on its first turn.
coord.register_agent(name)?;
coord.notify_manager(&hive_sh4re::HelperEvent::Spawned { coord.notify_manager(&hive_sh4re::HelperEvent::Spawned {
agent: name.to_owned(), agent: name.to_owned(),
ok: true, ok: true,
@ -223,7 +227,8 @@ async fn handle_spawn(coord: &Arc<Coordinator>, name: &str) -> Result<HostRespon
tokio::spawn(lifecycle::sync_tmpfiles()); tokio::spawn(lifecycle::sync_tmpfiles());
} }
Err(e) => { Err(e) => {
coord.unregister_agent(name); // Spawn failed: register_agent was never called, so there is
// nothing to unregister. Notify the manager and propagate.
coord.notify_manager(&hive_sh4re::HelperEvent::Spawned { coord.notify_manager(&hive_sh4re::HelperEvent::Spawned {
agent: name.to_owned(), agent: name.to_owned(),
ok: false, ok: false,