diff --git a/frontend/packages/dashboard/src/builds.js b/frontend/packages/dashboard/src/builds.js index 6b161ab7..04a77ded 100644 --- a/frontend/packages/dashboard/src/builds.js +++ b/frontend/packages/dashboard/src/builds.js @@ -376,12 +376,17 @@ function renderQueueEntry(entry) { chip.append(el('span', { class: 'rqe-node-agent' }, ' ยท ' + n.agent)); } row.append(chip); - if (n.has_log) { + if (n.build_log_id != null) { + // Deep-links into the BUILD L0GS tab's rich view (auto-expands + + // scrolls to this row there, see fetchBuild's `?id=N` handling) + // rather than the raw-text download endpoint โ€” a plain download + // is surprising here since nothing about a printer-glyph icon + // says "this leaves the app". The raw download is still one + // click away once on that row. row.append(el('a', { class: 'rqe-log-link rqe-node-log', - href: '/api/build-log/' + n.id + '/raw', - target: '_blank', - title: 'download build log for ' + n.kind + ' node', + href: '/builds.html?id=' + n.build_log_id + '#buildlogs', + title: 'view build log for ' + n.kind + ' node', }, 'โŽ™')); } treeRoot.append(row); diff --git a/hive-c0re/src/job_queue/mod.rs b/hive-c0re/src/job_queue/mod.rs index 1bce674f..3cb8efd2 100644 --- a/hive-c0re/src/job_queue/mod.rs +++ b/hive-c0re/src/job_queue/mod.rs @@ -559,7 +559,8 @@ impl QueueInner { } else { Vec::new() }; - let has_log = self.node_rt.get(&id).and_then(|r| r.build_log_id).is_some(); + let build_log_id = self.node_rt.get(&id).and_then(|r| r.build_log_id); + let has_log = build_log_id.is_some(); // `node.parent` is the structural jobq parent. Top-level nodes // have `parent == Some(container)` (direct children of the Dag // container); those become `parent: None` on the wire since the @@ -581,6 +582,7 @@ impl QueueInner { approval_id, inputs, has_log, + build_log_id, parent, }); } diff --git a/hive-host-sock/src/jobs.rs b/hive-host-sock/src/jobs.rs index d8d568e4..50394821 100644 --- a/hive-host-sock/src/jobs.rs +++ b/hive-host-sock/src/jobs.rs @@ -111,6 +111,12 @@ pub struct NodeView { /// store-only nodes don't render a link that 404s. #[serde(default)] pub has_log: bool, + /// The underlying build-log history row id, when this node has a + /// captured log (`Some` iff `has_log`). Lets the client deep-link to the + /// rich BUILD L0GS tab view (`/builds.html?id=#buildlogs`) instead of + /// only the raw-text download endpoint. + #[serde(default, skip_serializing_if = "Option::is_none")] + pub build_log_id: Option, /// Structural parent in the jobq tree โ€” `None` for top-level nodes /// (direct children of the DAG container). Sub-nodes carry the id of /// their containing parent node. The client uses this to render the diff --git a/hivectl/src/dag_progress.rs b/hivectl/src/dag_progress.rs index cfe658b1..059b8c11 100644 --- a/hivectl/src/dag_progress.rs +++ b/hivectl/src/dag_progress.rs @@ -343,6 +343,7 @@ mod tests { approval_id: None, inputs: vec![], has_log: false, + build_log_id: None, } }