vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

swarm-otel: name the port-collision assertion instead of pointing below

Browse source 
The three port descriptions in swarm-otel-service.nix said "the
assertion(s) below", but the assertion lives in swarm-otel.nix, on the
host that runs the collector. Describe it in this file's terms, and drop
the release anecdote from the port option's description.

Refs #3742
This commit is contained in:
atlas 2026-10-05 19:22:55 +02:00
commit 5d6ebda3e8
1 changed files with 10 additions and 10 deletions
Download patch file Download diff file Expand all files Collapse all files

20
nix/host-modules/swarm-otel-service.nix
View file

@ -79,10 +79,10 @@ in
and every swarm container shares the host's network namespace. Two and every swarm container shares the host's network namespace. Two
listeners claiming one port on one host is not a build failure — listeners claiming one port on one host is not a build failure —
it is a runtime coin toss over which one gets it, with nothing in it is a runtime coin toss over which one gets it, with nothing in
any log saying so. The same collision cost a release when grafana any log saying so. On the host running this collector, an
and the forge both defaulted to 3000. The assertions below check assertion rejects a derived range that overlaps any other port
the whole derived range against every port this module and the hive this module or the hive tier declares, which is as far as a module
tier declare, which is as far as a module can see. can see.
''; '';
}; };
@ -132,10 +132,10 @@ in
⚠️ Deliberately NOT derived from `port + (number of hives)`: that ⚠️ Deliberately NOT derived from `port + (number of hives)`: that
range grows every time a hive is added, and a fixed offset from range grows every time a hive is added, and a fixed offset from
it would silently start colliding once the hive count caught up. it would silently start colliding once the hive count caught up.
Kept as its own reserved value instead, and the assertion below Kept as its own reserved value instead, and the port-collision
still catches a real collision (including one hive growth assertion still rejects a real collision (including one hive
eventually causes) rather than starting a collector that quietly growth eventually causes) rather than starting a collector that
drops one receiver's samples. quietly drops one receiver's samples.
''; '';
}; };
@ -160,8 +160,8 @@ in
⚠️ A reserved value rather than an offset from ⚠️ A reserved value rather than an offset from
{option}`services.hyperhive.swarm.otel.port`, for the reason stated {option}`services.hyperhive.swarm.otel.port`, for the reason stated
on `producerPort`: that range grows with the hive count and would on `producerPort`: that range grows with the hive count and would
eventually walk into any fixed offset from it. The collision eventually walk into any fixed offset from it. The port-collision
assertion below covers this port too. assertion covers this port too.
''; '';
}; };