vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(dashboard): auto-reset stale per-agent questions filter on re-render

Browse source 
If the operator had an agent:foo filter active and all of foo's questions
were resolved, foo's chip disappears from the filter row on the next
render — but the stored filter value is still agent:foo. The section
then shows "no questions match this filter" with no active chip visible,
leaving the operator confused.

Fix: compute the set of valid filter values (all, operator, peer, plus
one agent:<name> per current participant) before rendering. If the stored
value is not in the set, silently reset it to 'all'. Write directly to
localStorage rather than via setQuestionsFilter() to avoid a re-entrant
renderQuestions() call.
This commit is contained in:
iris 2026-06-05 11:41:57 +02:00 • committed by mara
commit 59798f72f1
1 changed files with 18 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

20
frontend/packages/dashboard/src/tabs.js
View file

@ -1574,8 +1574,6 @@ window.marked = marked;
root.replaceChildren();
const fmt = (n) => new Date(n * 1000).toISOString().replace('T', ' ').slice(0, 19);
const allPending = questionsState.pending;
const activeFilter = getQuestionsFilter();
const pending = allPending.filter((q) => questionMatchesFilter(q, activeFilter));
// Filter chips. Always include `all` / `operator` / `peer`; add
// per-agent chips for any agent that appears as asker or target
@ -1586,6 +1584,24 @@ window.marked = marked;
participants.add(q.asker);
if (q.target) participants.add(q.target);
}
// Auto-reset a stale per-agent filter: if the operator had `agent:foo`
// selected and all of foo's questions resolved, foo's chip disappears
// from the row. Without a reset the section would show "no questions
// match this filter" with no active chip visible — confusing. Fall back
// to `all` whenever the stored value is no longer a valid chip value.
let activeFilter = getQuestionsFilter();
const validFilters = new Set(['all', 'operator', 'peer',
...Array.from(participants).map((n) => 'agent:' + n)]);
if (!validFilters.has(activeFilter)) {
activeFilter = 'all';
// Write directly to localStorage to avoid the re-render that
// setQuestionsFilter() triggers (we're already mid-render).
localStorage.setItem(QUESTIONS_FILTER_KEY, 'all');
}
const pending = allPending.filter((q) => questionMatchesFilter(q, activeFilter));
const filterRow = el('div', { class: 'questions-filters' });
const mkChip = (value, label) => {
const b = el('button', {