vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

chore(#2400): skip the prebuild warm-build when the container is down

Browse source
This commit is contained in:
damocles 2026-07-13 16:12:40 +02:00 • committed by mara
commit 4be2279485
2 changed files with 21 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

21
hive-c0re/src/job_queue/exec.rs
View file

@ -104,7 +104,11 @@ pub(super) async fn run_node(coord: &Arc<Coordinator>, claim: &Claim) -> Result<
/// Out-of-band toplevel build while the container keeps serving: meta /// Out-of-band toplevel build while the container keeps serving: meta
/// sync + optional per-agent relock, then warm /// sync + optional per-agent relock, then warm
/// `system.build.toplevel` so the later `Swap` hits cache and skips /// `system.build.toplevel` so the later `Swap` hits cache and skips
/// straight to the profile-swap. /// straight to the profile-swap. The warm build is skipped when the
/// container is already down: its only purpose is to shrink the swap's
/// downtime window, so a stopped agent (no uptime to preserve) doesn't
/// pay the double eval — `Swap` builds inline instead. The meta sync +
/// dir prep still run unconditionally (the `Swap` depends on them).
async fn run_prebuild( async fn run_prebuild(
coord: &Arc<Coordinator>, coord: &Arc<Coordinator>,
claim: &Claim, claim: &Claim,
@ -134,9 +138,18 @@ async fn run_prebuild(
crate::meta::lock_update_for_rebuild(name).await?; crate::meta::lock_update_for_rebuild(name).await?;
} }
} }
ctx.step("nix build"); // Warm the toplevel build only when the container is up — the whole
let flake_ref = format!("{}#{name}", crate::paths::meta_root().display()); // point of prebuild is to shrink the swap's downtime window. A
crate::lifecycle::prebuild_toplevel(name, &flake_ref, &|log_id| ctx.build_log(log_id)).await?; // stopped agent has no uptime to preserve, so skip the (expensive)
// eval and let the downstream `Swap` build inline.
if crate::lifecycle::is_running(name).await {
ctx.step("nix build");
let flake_ref = format!("{}#{name}", crate::paths::meta_root().display());
crate::lifecycle::prebuild_toplevel(name, &flake_ref, &|log_id| ctx.build_log(log_id))
.await?;
} else {
ctx.step("skipped prebuild (container down)");
}
Ok(NodeOutput::default()) Ok(NodeOutput::default())
} }

5
hive-c0re/src/job_queue/model.rs
View file

@ -68,7 +68,10 @@ pub enum NodeKind {
/// meta `sync_agents`, optional per-agent relock, then /// meta `sync_agents`, optional per-agent relock, then
/// `lifecycle::prebuild_toplevel`. `relock = false` only for /// `lifecycle::prebuild_toplevel`. `relock = false` only for
/// meta-update cascade rebuilds (re-locking would revert the bump /// meta-update cascade rebuilds (re-locking would revert the bump
/// the cascade just committed). /// the cascade just committed). The `prebuild_toplevel` warm is
/// skipped when the container is already down — it only exists to
/// shrink the swap's downtime, which a stopped agent doesn't need
/// (the sync + dir prep still run; `Swap` builds inline).
Prebuild { relock: bool }, Prebuild { relock: bool },
/// `nixos-container update` profile-swap (requires the container /// `nixos-container update` profile-swap (requires the container
/// stopped). Re-applies nspawn flags + resource limits first — /// stopped). Re-applies nspawn flags + resource limits first —