From 450efd5429ef72cf8891f4ed0fe716fb7b63bdba Mon Sep 17 00:00:00 2001 From: damocles Date: Mon, 1 Jun 2026 11:02:09 +0200 Subject: [PATCH] refactor: rename manager-only annotations to privileged in Request enum --- hive-sh4re/src/lib.rs | 36 ++++++++++++++++++------------------ 1 file changed, 18 insertions(+), 18 deletions(-) diff --git a/hive-sh4re/src/lib.rs b/hive-sh4re/src/lib.rs index 7b6ada12..45488fcf 100644 --- a/hive-sh4re/src/lib.rs +++ b/hive-sh4re/src/lib.rs @@ -296,8 +296,8 @@ pub enum CancelLooseEndKind { } /// Unified request enum for both agent and manager sockets. The agent's -/// identity is the socket it arrived on. Manager-only variants are marked -/// `*(manager only)*` — an agent socket returns `Err` for them server-side. +/// identity is the socket it arrived on. Privileged variants are marked +/// `*(privileged)*` — an agent socket returns `Err` for them server-side. /// /// `AgentRequest` and `ManagerRequest` are type aliases for this enum; /// existing callers continue to compile unchanged. @@ -428,57 +428,57 @@ pub enum Request { /// `docs/conventions.md::Broker delivery + ack cycle`. RequeueInflight, - // ---- manager socket only ------------------------------------------------ + // ---- privileged (manager socket only for now) --------------------------- - /// *(manager only)* Initialise a brand-new agent's proposed config repo + /// *(privileged)* Initialise a brand-new agent's proposed config repo /// and queue an approval for the operator to review. RequestInitConfig { name: String, #[serde(default, skip_serializing_if = "Option::is_none")] description: Option, }, - /// *(manager only)* Stop a sub-agent (graceful). + /// *(privileged)* Stop a sub-agent (graceful). Kill { name: String }, - /// *(manager only)* Start a previously-stopped sub-agent container. + /// *(privileged)* Start a previously-stopped sub-agent container. Start { name: String }, - /// *(manager only)* Restart a sub-agent container (stop + start). + /// *(privileged)* Restart a sub-agent container (stop + start). Restart { name: String }, - /// *(manager only)* Rebuild a sub-agent against the current hyperhive + /// *(privileged)* Rebuild a sub-agent against the current hyperhive /// flake + agent.nix. No approval required. Update { name: String }, - /// *(manager only)* Submit a config commit for the operator to approve. + /// *(privileged)* Submit a config commit for the operator to approve. RequestApplyCommit { agent: String, commit_ref: String, #[serde(default, skip_serializing_if = "Option::is_none")] description: Option, }, - /// *(manager only)* Fetch recent journal lines for a sub-agent container. + /// *(privileged)* Fetch recent journal lines for a sub-agent container. GetLogs { agent: String, #[serde(default)] lines: Option, }, - /// *(manager only)* Queue an approval to run `nix flake update [inputs...]`. + /// *(privileged)* Queue an approval to run `nix flake update [inputs...]`. RequestUpdateMetaInputs { #[serde(default)] inputs: Vec, #[serde(default, skip_serializing_if = "Option::is_none")] description: Option, }, - /// *(manager only)* Queue an approval to add a scheduled prompt. + /// *(privileged)* Queue an approval to add a scheduled prompt. RequestSchedulePrompt(SchedulePromptPayload), - /// *(manager only)* Cancel a scheduled prompt. + /// *(privileged)* Cancel a scheduled prompt. CancelSchedule { id: i64, #[serde(default, skip_serializing_if = "Option::is_none")] targets: Option>, }, - /// *(manager only)* List every schedule in the queue. + /// *(privileged)* List every schedule in the queue. ListSchedules, - /// *(manager only)* Fire a scheduled prompt out of band immediately. + /// *(privileged)* Fire a scheduled prompt out of band immediately. FireScheduleNow { id: i64 }, - /// *(manager only)* Edit an existing schedule's mutable fields. + /// *(privileged)* Edit an existing schedule's mutable fields. EditSchedule { id: i64, #[serde(default, skip_serializing_if = "Option::is_none")] @@ -497,12 +497,12 @@ pub enum Request { } /// Backwards-compatible aliases. Both sockets now speak the unified `Request` -/// / `Response` wire; the server-side privilege gate rejects manager-only +/// / `Response` wire; the server-side privilege gate rejects privileged /// variants on agent sockets with `Err { message: "privileged variant..." }`. pub type AgentRequest = Request; pub type ManagerRequest = Request; -/// Unified response enum for both agent and manager sockets. Manager-only +/// Unified response enum for both agent and manager sockets. Privileged /// variants (`Logs`, `Schedules`) are never returned on agent sockets. /// /// `AgentResponse` and `ManagerResponse` are type aliases for this enum.