agent: meta-nav popout + header height fix + badge row consistency
mara, live review: 'the login card looks like it is behind the header', 'badges and interactive elements on same row have inconsistent size', 'the links should have the same popout as the links in the nav bar of swarm-ui.' All three, addressed: - Root cause of the overlap: MetaNav rendered every link inline in the header's title row, a variable-width list that can grow the row past the fixed --agent-header-h the rest of the page (position: fixed header, position: absolute content below it) is offset against, so the header visually covers whatever's underneath it once it's actually taller than assumed. Fix: MetaNav is now a single fixed-size trigger (reuses @hive/shared's Badge, icon-only, same shape as the header's existing overflow trigger) in the pills cluster, not a variable-width list in the title row. A single badge can't grow the row regardless of how many links the backend sends. Verified at 1024px/1400px (no overlap, was previously untested below 1400px) — the deeper fragility (StatusChips' badge row itself can still wrap on a genuinely narrow/mobile viewport and hit the same class of bug) is real but predates this PR and is out of scope here. - The popover mara asked for: same visual language as swarm-ui's own LinksMenu (Shell/LinksMenu.tsx) and this page's Dropdown/OverflowMenu — quiet icon trigger, popover on click. Not built from @hive/shared's Dropdown itself (its items are always <button>s for command dispatch, which would lose real <a> link semantics — ctrl/middle-click, copy
This commit is contained in:
parent
df78236ce4
commit
3ce961e5bd
5 changed files with 152 additions and 43 deletions
|
|
@ -27,24 +27,29 @@ export interface HeaderProps {
|
|||
label: string;
|
||||
hiveLabel?: string | null;
|
||||
children?: ComponentChildren;
|
||||
/** Meta-nav links (stats/screen/forge/config/extras) — `<MetaNav>`
|
||||
* lands here, in the title row alongside the `<h2>`, same as the old
|
||||
* markup's `<nav id="meta-links">` (docs/web-ui/agent.md::Header). */
|
||||
nav?: ComponentChildren;
|
||||
/** Right-cluster flyout triggers (inbox/todos pills today, the
|
||||
* overflow menu button lands here in a later commit) — mirrors the
|
||||
* old markup's `.agent-header-pills` third column. */
|
||||
/** Right-cluster flyout triggers (inbox/todos/links pills, the
|
||||
* overflow menu button) — mirrors the old markup's
|
||||
* `.agent-header-pills` third column. Meta-nav (`<MetaNav>`) lives
|
||||
* here too, as a fixed-size trigger — NOT in the title row the old
|
||||
* markup put it in (`<nav id="meta-links">`, docs/web-ui/agent.md).
|
||||
* A variable-width inline link list there grows the title row's
|
||||
* actual height past the fixed `--agent-header-h` the rest of the
|
||||
* page's `position: fixed` header + `position: absolute` content
|
||||
* below it are offset against, so on a narrow viewport the header
|
||||
* silently overlaps the login-recovery card underneath it (mara,
|
||||
* live: "the login card looks like it is behind the header"). A
|
||||
* fixed-size trigger button can't do that regardless of how many
|
||||
* links the backend sends. */
|
||||
pills?: ComponentChildren;
|
||||
}
|
||||
|
||||
export function Header({ label, hiveLabel, children, nav, pills }: HeaderProps) {
|
||||
export function Header({ label, hiveLabel, children, pills }: HeaderProps) {
|
||||
return (
|
||||
<header class="agent-header">
|
||||
<img class="agent-icon" src="icon" alt="" onError={handleIconError} />
|
||||
<div class="agent-header-main">
|
||||
<div class="agent-header-row agent-header-title-row">
|
||||
<h2 class="agent-header-title">◆ {label} ◆</h2>
|
||||
{nav}
|
||||
</div>
|
||||
{hiveLabel ? <div class="agent-header-row agent-hive-row">{hiveLabel}</div> : null}
|
||||
<div class="agent-header-row">{children}</div>
|
||||
|
|
|
|||
Loading…
Reference in a new issue