hive-forge: ci-rerun --run refuses on a PR-triggered run too
--run <id> against a run that was itself PR-triggered has the identical defect #4632 fixed for --pr: a workflow_dispatch run writes no commit status, so it can't clear the red (pull_request) check on that PR's sha no matter how the dispatched run turns out. resolve_run already distinguishes this case -- it recognizes a run's prettyref as a PR pseudo-ref (#<n>) via pr_number_from_run_ref, then used to call branch_for_pr to keep going. It now bails with the same pr_refusal_message --pr uses instead, before ever building a dispatch request. branch_for_pr has no other caller (--pr refuses before touching it too, since #4632), so it's removed rather than left dead. Push (non-PR-triggered) and --branch are untouched. Regenerated docs/tools/forge-cli.md from clap help; corrected docs/tools/forge.md's claim that --run always works.
This commit is contained in:
parent
8de85729cc
commit
392f16cbc0
3 changed files with 55 additions and 47 deletions
|
|
@ -1371,7 +1371,7 @@ Re-run CI without an empty commit. Pass one of `--pr <n>`, `--run <n>`, or `--br
|
|||
###### **Options:**
|
||||
|
||||
* `--pr <PR>` — Doesn't work: a `workflow_dispatch` run writes no commit status, so it can't clear a red `(pull_request)` check — re-run from the web UI instead. Mutually exclusive with `--run` / `--branch`
|
||||
* `--run <RUN>` — Re-run the same workflow on the same branch this run used. The run number is the `runs/<n>` in the run-page URL. Mutually exclusive with `--pr` / `--branch`
|
||||
* `--run <RUN>` — Re-run the same workflow on the same branch this run used. The run number is the `runs/<n>` in the run-page URL. Refuses instead of dispatching if the run was itself PR-triggered, same as `--pr` and for the same reason. Mutually exclusive with `--pr` / `--branch`
|
||||
* `--branch <BRANCH>` — Re-run `--workflow` on this branch. Mutually exclusive with `--pr` / `--run`
|
||||
* `--workflow <WORKFLOW>` — Workflow file to run (default `ci.yml`). Ignored for `--run`, which uses the run's own workflow
|
||||
|
||||
|
|
|
|||
Loading…
Reference in a new issue