From 374e53d13ed319ac589c8cde2924463c7ecf64e1 Mon Sep 17 00:00:00 2001 From: damocles Date: Wed, 3 Jun 2026 16:01:32 +0200 Subject: [PATCH] nit(#1141): suppress :line in text output when comment has no line number --- hive-forge/src/verbs/pr_reviews.rs | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-) diff --git a/hive-forge/src/verbs/pr_reviews.rs b/hive-forge/src/verbs/pr_reviews.rs index e2ab8086..91b9d2f8 100644 --- a/hive-forge/src/verbs/pr_reviews.rs +++ b/hive-forge/src/verbs/pr_reviews.rs @@ -145,13 +145,12 @@ fn list_reviews(client: &Client, number: u64) -> Result<()> { if id > 0 { for c in &fetch_inline_comments(client, repo, number, id) { let path = c.get("path").and_then(Value::as_str).unwrap_or("?"); - let line = c - .get("line") - .and_then(Value::as_u64) - .map(|n| n.to_string()) - .unwrap_or_else(|| "?".to_string()); let cbody = c.get("body").and_then(Value::as_str).unwrap_or("").trim(); - println!(" [{path}:{line}] {cbody}"); + // PR-level comments have no line; omit `:line` when absent. + match c.get("line").and_then(Value::as_u64) { + Some(line) => println!(" [{path}:{line}] {cbody}"), + None => println!(" [{path}] {cbody}"), + } } } println!();