cut the comments back to what the code cannot say
mara: comments to code ratio too high. It was 16 comment lines for one line of feature. Kept only the fact that stops the feature being trimmed away again - it is not a transport, it is in `default`, so `default-features = false` drops it - and, in hive-metric, the one reason its declaration deliberately differs. Why an HTTP 200 is the failure that matters, and what a stderr-reporting CLI would cost, are the PR's and the follow-up issue's job, not the manifest's.
This commit is contained in:
parent
b28af3cd1f
commit
34fed47400
2 changed files with 7 additions and 16 deletions
|
|
@ -20,18 +20,14 @@ clap.workspace = true
|
||||||
clap_complete.workspace = true
|
clap_complete.workspace = true
|
||||||
clap-markdown = "0.1"
|
clap-markdown = "0.1"
|
||||||
# OTEL SDK for the per-agent container-resource metrics exporter
|
# OTEL SDK for the per-agent container-resource metrics exporter
|
||||||
# (stats/otel_metrics.rs). Same versions as hive-metric, and the same blocking
|
# (stats/otel_metrics.rs). Same versions as hive-metric — the blocking OTLP
|
||||||
# OTLP client for the same reason: the metrics SDK's PeriodicReader runs on a
|
# client is deliberate: the metrics SDK's PeriodicReader runs on a background
|
||||||
# background thread with no Tokio reactor, where the async client panics.
|
# thread with no Tokio reactor, where the async client panics.
|
||||||
# Features differ by one — see `internal-logs` below and hive-metric's note.
|
|
||||||
opentelemetry = "0.32"
|
opentelemetry = "0.32"
|
||||||
opentelemetry_sdk = { version = "0.32", features = ["metrics"] }
|
opentelemetry_sdk = { version = "0.32", features = ["metrics"] }
|
||||||
opentelemetry-otlp = { version = "0.32", default-features = false, features = [
|
opentelemetry-otlp = { version = "0.32", default-features = false, features = [
|
||||||
# Not a transport — this is the exporter's own diagnostics, and it is in
|
# Not a transport: it is in `default`, so `default-features = false` drops the
|
||||||
# `default`, so `default-features = false` drops it unless it is named here.
|
# exporter's own diagnostics unless it is named here.
|
||||||
# Without it every `otel_warn!`/`otel_debug!` *inside this crate* compiles to
|
|
||||||
# nothing, and the one failure that returns HTTP 200 — the collector accepting
|
|
||||||
# the request and rejecting the data points — is reported nowhere at all.
|
|
||||||
"internal-logs",
|
"internal-logs",
|
||||||
"metrics",
|
"metrics",
|
||||||
"http-json",
|
"http-json",
|
||||||
|
|
|
||||||
|
|
@ -19,13 +19,8 @@ opentelemetry_sdk = { version = "0.32", features = ["metrics"] }
|
||||||
# so the async client panics there with "no reactor running". The blocking
|
# so the async client panics there with "no reactor running". The blocking
|
||||||
# client sends on that thread directly — and for a fire-and-forget CLI that
|
# client sends on that thread directly — and for a fire-and-forget CLI that
|
||||||
# records one point then `shutdown()`s, a synchronous send is exactly right.
|
# records one point then `shutdown()`s, a synchronous send is exactly right.
|
||||||
#
|
# No `internal-logs` here, unlike hive-c0re: this binary installs no tracing
|
||||||
# Deliberately WITHOUT the `internal-logs` feature that `hive-c0re` names, even
|
# subscriber, so the SDK's diagnostics would have nowhere to go.
|
||||||
# though the defect is identical: this binary installs no `tracing` subscriber,
|
|
||||||
# so the SDK's diagnostics would be emitted into a void. Enabling it here would
|
|
||||||
# read as "hive-metric reports its export failures" while changing nothing at
|
|
||||||
# all. Giving this CLI somewhere to report is a behaviour change with its own
|
|
||||||
# decision (does a metrics push print to stderr?) — tracked separately.
|
|
||||||
opentelemetry-otlp = { version = "0.32", default-features = false, features = [
|
opentelemetry-otlp = { version = "0.32", default-features = false, features = [
|
||||||
"metrics",
|
"metrics",
|
||||||
"http-json",
|
"http-json",
|
||||||
|
|
|
||||||
Loading…
Reference in a new issue