vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

cut the comments back to what the code cannot say

Browse source 
mara: comments to code ratio too high. It was 16 comment lines for one
line of feature.

Kept only the fact that stops the feature being trimmed away again - it
is not a transport, it is in `default`, so `default-features = false`
drops it - and, in hive-metric, the one reason its declaration
deliberately differs. Why an HTTP 200 is the failure that matters, and
what a stderr-reporting CLI would cost, are the PR's and the follow-up
issue's job, not the manifest's.
This commit is contained in:
atlas 2026-08-14 16:02:10 +02:00 • committed by mara
commit 34fed47400
2 changed files with 7 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

14
hive-c0re/Cargo.toml
View file

@ -20,18 +20,14 @@ clap.workspace = true
clap_complete.workspace = true
clap-markdown = "0.1"
# OTEL SDK for the per-agent container-resource metrics exporter
# (stats/otel_metrics.rs). Same versions as hive-metric, and the same blocking
# OTLP client for the same reason: the metrics SDK's PeriodicReader runs on a
# background thread with no Tokio reactor, where the async client panics.
# Features differ by one — see `internal-logs` below and hive-metric's note.
# (stats/otel_metrics.rs). Same versions as hive-metric — the blocking OTLP
# client is deliberate: the metrics SDK's PeriodicReader runs on a background
# thread with no Tokio reactor, where the async client panics.
opentelemetry = "0.32"
opentelemetry_sdk = { version = "0.32", features = ["metrics"] }
opentelemetry-otlp = { version = "0.32", default-features = false, features = [
# Not a transport — this is the exporter's own diagnostics, and it is in
# `default`, so `default-features = false` drops it unless it is named here.
# Without it every `otel_warn!`/`otel_debug!` *inside this crate* compiles to
# nothing, and the one failure that returns HTTP 200 — the collector accepting
# the request and rejecting the data points — is reported nowhere at all.
# Not a transport: it is in `default`, so `default-features = false` drops the
# exporter's own diagnostics unless it is named here.
"internal-logs",
"metrics",
"http-json",