From 348b2f96da41b6f6cf6a4bf197cb57878978f46f Mon Sep 17 00:00:00 2001 From: iris Date: Sun, 16 Aug 2026 21:25:54 +0200 Subject: [PATCH] give the rollup glyph back its spin animation The extraction dropped the old banner's `spinner` class on the glyph span (`el('span', { class: 'glyph spinner' }, ...)`) - JobqRollup.tsx rendered a static `.jqr-glyph` with no animation rule anywhere. `.spinner` (shared/base.css) is already imported by both consumers, so just reuse it on the glyph rather than duplicating the keyframes. argus caught this on review - a single-frame screenshot can't tell a frozen spinner from a missing one, which is exactly why it slipped past the PR's visual verification. --- frontend/packages/shared/src/jobq-rollup/JobqRollup.tsx | 7 ++++++- 1 file changed, 6 insertions(+), 1 deletion(-) diff --git a/frontend/packages/shared/src/jobq-rollup/JobqRollup.tsx b/frontend/packages/shared/src/jobq-rollup/JobqRollup.tsx index 2f946b58..a84e8a1e 100644 --- a/frontend/packages/shared/src/jobq-rollup/JobqRollup.tsx +++ b/frontend/packages/shared/src/jobq-rollup/JobqRollup.tsx @@ -18,6 +18,11 @@ // /builds.html; swarm-ui's /jobs page omits it — a link to the page // you're already on is noise). // +// The glyph carries `.spinner` (`@hive/shared/base.css`, already +// imported by both consumers) for the "actively happening" spin — +// not redeclared in jobq-rollup.css, since a static screenshot can't +// tell a frozen spinner from a missing one; caught by argus's review. +// // Two ways to use this, same shape as JobqGraph: JSX (swarm-ui) — // ``. Or imperative mount // (dashboard/src/swarm.js, plain `.js`) — `mountJobqRollup(container, @@ -76,7 +81,7 @@ export function JobqRollup({ endpoint, queueHref, refreshToken = 0 }: JobqRollup return (
- ◐{' '} + {' '} build queue — {parts.join(' · ')}{' '} {queueHref && ( view queue →