vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

hive-forge: regenerate forge-cli.md, pin --ignore refusal with a test

Browse source
This commit is contained in:
damocles 2026-10-09 11:56:21 +02:00 • committed by mara
commit 31c7623a69
2 changed files with 33 additions and 16 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/tools/forge-cli.md
View file

@ -1278,7 +1278,7 @@ Get/set this user's watch subscription on a repo, or --list all watched repos
###### **Options:** ###### **Options:**
* `--watch` — Subscribe (watch the repo) * `--watch` — Subscribe (watch the repo)
* `--ignore` — Mute (mark ignored) * `--ignore` — Unsupported: Forgejo's subscription endpoint can't mark a repo ignored without also watching it. Always refuses with an error
* `--unwatch` — Unsubscribe (clear watch + ignore) * `--unwatch` — Unsubscribe (clear watch + ignore)
* `--list` — List every repo the current user watches (ignores `[repo]`) * `--list` — List every repo the current user watches (ignores `[repo]`)

47
hive-forge/src/verbs/subscription.rs
View file

@ -40,7 +40,26 @@ pub struct Args {
/// # Errors /// # Errors
/// Propagates transport / non-2xx errors from the Forgejo client calls /// Propagates transport / non-2xx errors from the Forgejo client calls
/// and from `print_json`. /// and from `print_json`.
/// Error text for a refused `--ignore`. Forgejo's PUT subscription endpoint
/// takes no body — it always subscribes (watch), with no way to mark a repo
/// ignored without also watching it. The old raw client sent a
/// `{subscribed, ignored}` body which the server ignored, so `--ignore`
/// silently behaved like `--watch` (the opposite of what it promises)
/// instead of failing. Refuse instead of lying about what happened. A free
/// function (rather than inlined in `run`) so it's testable without a real
/// `Client` — the refusal fires before any API call is made.
fn ignore_refusal_message() -> String {
"subscription --ignore is not supported: Forgejo's subscription endpoint \
has no way to mark a repo ignored without also watching it. Use \
--unwatch to stop watching, or --watch if muted-but-watched is what \
you actually want."
.to_owned()
}
pub fn run(client: &Client, args: Args) -> Result<()> { pub fn run(client: &Client, args: Args) -> Result<()> {
if args.ignore {
anyhow::bail!(ignore_refusal_message());
}
if args.list { if args.list {
// List every repo the authed user watches, so an agent can audit // List every repo the authed user watches, so an agent can audit
// its notification firehose and decide what to `--unwatch`. Not // its notification firehose and decide what to `--unwatch`. Not
@ -73,21 +92,6 @@ pub fn run(client: &Client, args: Args) -> Result<()> {
println!("unsubscribed"); println!("unsubscribed");
return Ok(()); return Ok(());
} }
if args.ignore {
// Forgejo's PUT subscription endpoint takes no body — it always
// subscribes (watch), it has no way to mark a repo ignored
// without also watching it. The old raw client sent a
// `{subscribed, ignored}` body which the server ignored, so
// `--ignore` silently behaved like `--watch` (the opposite of
// what it promises) instead of failing. Refuse instead of lying
// about what happened.
anyhow::bail!(
"subscription --ignore is not supported: Forgejo's subscription \
endpoint has no way to mark a repo ignored without also \
watching it. Use --unwatch to stop watching, or --watch if \
muted-but-watched is what you actually want."
);
}
if args.watch { if args.watch {
let resp = client let resp = client
.api() .api()
@ -113,3 +117,16 @@ pub fn run(client: &Client, args: Args) -> Result<()> {
Err(e) => Err(e.into()), Err(e) => Err(e.into()),
} }
} }
#[cfg(test)]
mod tests {
use super::ignore_refusal_message;
#[test]
fn ignore_is_rejected_pointing_at_unwatch() {
let msg = ignore_refusal_message();
assert!(msg.contains("--unwatch"));
assert!(msg.contains("--watch"));
assert!(msg.contains("not supported"));
}
}