refactor(#1474): replace too_many_arguments allows on pub fns with param structs

hive-c0re/src/coordinator.rs

@@ -349,6 +349,33 @@ impl TransientKind {
     }
 }
 
+/// Field-named payload for [`Coordinator::emit_approval_resolved`].
+/// Mirrors the `ApprovalResolved` dashboard-event fields. `agent`
+/// borrows from the caller; `approval_kind` / `status` are
+/// compile-time constants.
+pub struct ApprovalResolved<'a> {
+    pub id: i64,
+    pub agent: &'a str,
+    pub approval_kind: &'static str,
+    pub sha_short: Option<String>,
+    pub status: &'static str,
+    pub note: Option<String>,
+    pub description: Option<String>,
+}
+
+/// Field-named payload for [`Coordinator::emit_question_added`].
+/// Mirrors the `QuestionAdded` dashboard-event fields; all references
+/// share the caller's lifetime.
+pub struct QuestionAdded<'a> {
+    pub id: i64,
+    pub asker: &'a str,
+    pub question: &'a str,
+    pub options: &'a [String],
+    pub multi: bool,
+    pub deadline_at: Option<i64>,
+    pub target: Option<&'a str>,
+}
+
 impl Coordinator {
     pub fn open(
         db_path: &Path,
@@ -652,21 +679,19 @@ impl Coordinator {
     /// already have an authoritative timestamp from the db update,
     /// the tiny skew between "row updated" and "event emitted" is
     /// presentation-only and doesn't matter to clients.
-    #[allow(
-        clippy::too_many_arguments,
-        reason = "args mirror the approval-resolved event payload fields; \
-                  bundling them into a struct used only here adds no clarity"
-    )]
-    pub fn emit_approval_resolved(
-        &self,
-        id: i64,
-        agent: &str,
-        approval_kind: &'static str,
-        sha_short: Option<String>,
-        status: &'static str,
-        note: Option<String>,
-        description: Option<String>,
-    ) {
+    ///
+    /// Takes [`ApprovalResolved`] rather than a positional arg list so
+    /// the seven fields are named at every call site.
+    pub fn emit_approval_resolved(&self, ev: ApprovalResolved<'_>) {
+        let ApprovalResolved {
+            id,
+            agent,
+            approval_kind,
+            sha_short,
+            status,
+            note,
+            description,
+        } = ev;
         let resolved_at = std::time::SystemTime::now()
             .duration_since(std::time::UNIX_EPOCH)
             .ok()
@@ -689,21 +714,16 @@ impl Coordinator {
     /// both operator-targeted (`target = None`) and peer-to-peer
     /// (`target = Some(agent)`) threads — the dashboard surfaces
     /// both, distinguishing visually + offering operator override.
-    #[allow(
-        clippy::too_many_arguments,
-        reason = "args mirror the question-added event payload fields; \
-                  bundling them into a struct used only here adds no clarity"
-    )]
-    pub fn emit_question_added(
-        &self,
-        id: i64,
-        asker: &str,
-        question: &str,
-        options: &[String],
-        multi: bool,
-        deadline_at: Option<i64>,
-        target: Option<&str>,
-    ) {
+    pub fn emit_question_added(&self, ev: &QuestionAdded<'_>) {
+        let &QuestionAdded {
+            id,
+            asker,
+            question,
+            options,
+            multi,
+            deadline_at,
+            target,
+        } = ev;
         let asked_at = std::time::SystemTime::now()
             .duration_since(std::time::UNIX_EPOCH)
             .ok()