vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

docs(approvals): fix deny-notification conditionality

Browse source 
argus review: the submitting agent is always notified when its request
is denied (HelperEvent::ApprovalResolved fires unconditionally); only
the reason text is optional, and only from the dashboard prompt (not
the CLI, which has no reason argument at all). Also note that
cancelling the dashboard prompt aborts the whole deny, not just the
reason.
This commit is contained in:
iris 2026-08-02 23:56:43 +02:00 • committed by mara
commit 2fb0d08274
1 changed files with 7 additions and 5 deletions
Download patch file Download diff file Expand all files Collapse all files

12
docs/approvals.md
View file

@ -41,11 +41,13 @@ CLI) before it takes effect. What you'll see, and what to do with it:
*agent* asking to schedule something, not for you doing it. *agent* asking to schedule something, not for you doing it.
Don't want to approve something? **Deny it** (`DENY` on the dashboard Don't want to approve something? **Deny it** (`DENY` on the dashboard
card, or `hivectl approvals deny <id>`) — nothing runs. The dashboard card, or `hivectl approvals deny <id>`) — nothing runs. Either way the
prompts for an optional reason, which lands directly in the submitting submitting agent is always notified their request was denied; what's
agent's inbox if you give one; the CLI denies without one. Denying is optional is only the reason text, which you can add on the dashboard's
final: a denied approval can't be re-approved later, the agent has to prompt (cancelling that prompt aborts the whole deny, not just the
submit a fresh one (a new PR, a new request). reason) but not from the CLI. Denying is final: a denied approval
can't be re-approved later, the agent has to submit a fresh one (a new
PR, a new request).
Everything below this point is the implementation detail behind that Everything below this point is the implementation detail behind that
flow. flow.