From 2b38805c00ad60947f5c0a029c597ba909a47f92 Mon Sep 17 00:00:00 2001
From: damocles <damocles@hyperhive>
Date: Mon, 18 May 2026 18:49:12 +0200
Subject: [PATCH] =?UTF-8?q?cancel=5Floose=5Fend:=20canonicalize=20kind=20i?=
 =?UTF-8?q?n=20success=20ack=20(alias=20'q'=20=E2=86=92=20'question')?=
MIME-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: 8bit

---
 hive-ag3nt/src/mcp.rs | 15 +++++++++++++--
 1 file changed, 13 insertions(+), 2 deletions(-)

diff --git a/hive-ag3nt/src/mcp.rs b/hive-ag3nt/src/mcp.rs
index 87b8350..ace175a 100644
--- a/hive-ag3nt/src/mcp.rs
+++ b/hive-ag3nt/src/mcp.rs
@@ -206,6 +206,17 @@ fn parse_loose_end_kind(raw: &str) -> Result<hive_sh4re::CancelLooseEndKind, Str
     }
 }
 
+/// Canonical user-facing label for a `CancelLooseEndKind` — used in
+/// the success ack so the caller always sees `"question"` /
+/// `"reminder"` instead of whatever alias they passed in (`"q"` /
+/// `"r"`).
+fn loose_end_kind_label(kind: hive_sh4re::CancelLooseEndKind) -> &'static str {
+    match kind {
+        hive_sh4re::CancelLooseEndKind::Question => "question",
+        hive_sh4re::CancelLooseEndKind::Reminder => "reminder",
+    }
+}
+
 /// Format helper for `whoami`: renders the identity block as a short
 /// human-readable string. Skips fields that are `None` so the output
 /// doesn't carry dead placeholders.
@@ -492,13 +503,13 @@ impl AgentServer {
     )]
     async fn cancel_loose_end(&self, Parameters(args): Parameters<CancelLooseEndArgs>) -> String {
         let log = format!("{args:?}");
-        let kind_label = args.kind.clone();
         let id = args.id;
         run_tool_envelope("cancel_loose_end", log, async move {
             let kind = match parse_loose_end_kind(&args.kind) {
                 Ok(k) => k,
                 Err(e) => return e,
             };
+            let kind_label = loose_end_kind_label(kind);
             let (resp, retries) = self
                 .dispatch(hive_sh4re::AgentRequest::CancelLooseEnd { kind, id })
                 .await;
@@ -1032,13 +1043,13 @@ impl ManagerServer {
     )]
     async fn cancel_loose_end(&self, Parameters(args): Parameters<CancelLooseEndArgs>) -> String {
         let log = format!("{args:?}");
-        let kind_label = args.kind.clone();
         let id = args.id;
         run_tool_envelope("cancel_loose_end", log, async move {
             let kind = match parse_loose_end_kind(&args.kind) {
                 Ok(k) => k,
                 Err(e) => return e,
             };
+            let kind_label = loose_end_kind_label(kind);
             let (resp, retries) = self
                 .dispatch(hive_sh4re::ManagerRequest::CancelLooseEnd { kind, id })
                 .await;