hive-c0re: a deploy request for a rev applied/main already contains is a no-op
advance_applied_main refused every rev that does not descend from applied/main, including an ancestor of it. Ancestors arrive in normal operation: swarm-controller queues each merge's TriggerDeploy as an independent node with no resource or edge between them and spawns each runnable node on its own task, so two merges of one agent can publish in either order; the meta-update cascade fast-forwards applied/main to the forge's main on its own; and the webhook handler does not dedup a redelivered merge event. Since a refusal now logs at ERROR and fires the `hh-config-rev-refused` alert, each of those would page as a refusal. An ancestor is now RevAdvance::Superseded, logged at info, nothing queued. Only a rev that has diverged (neither descendant nor ancestor) is refused. Refs #4851
This commit is contained in:
parent
8c222f8910
commit
29d956140e
3 changed files with 31 additions and 6 deletions
|
|
@ -44,10 +44,12 @@ No MCP tool exists for config changes: opening the PR IS the request.
|
|||
deploy subject. With no such hive, or more than one, it deploys
|
||||
nothing and logs a warning naming them.
|
||||
5. If the hive's `applied/main` already is that commit, it does nothing.
|
||||
Otherwise it fetches the config repo's `main`, requires the commit to
|
||||
descend from `applied/main`, fast-forwards `applied/main` to it, and
|
||||
queues a rebuild. A failure before the rebuild (the fetch, or a commit
|
||||
that doesn't descend) deploys nothing and logs `swarm events: rev not
|
||||
Otherwise it fetches the config repo's `main`. A commit that
|
||||
`applied/main` already contains is a no-op too: requests for two merges
|
||||
can arrive in either order. A commit that descends from `applied/main`
|
||||
is fast-forwarded to and a rebuild queued. A failure before the rebuild
|
||||
(the fetch, or a commit that has diverged from `applied/main`) deploys
|
||||
nothing and logs `swarm events: rev not
|
||||
applied; nothing queued` at error, which fires the Grafana alert
|
||||
`config rev refused`. An agent with no container on that hive yet ignores
|
||||
the commit; its first deploy builds what it seeds.
|
||||
|
|
|
|||
Loading…
Reference in a new issue