vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 2

swarm: say "no queue coordinates", never "a hive with no queue"

Browse source 
The swarm always has exactly one queue; a hive can only lack its
address. Reworded every prose site this PR added that stated or
implied the opposite, to name what is actually absent (coordinates,
credential, or address) instead of the queue itself.

Refs #3805
This commit is contained in:
atlas 2026-09-13 00:42:14 +02:00
commit 2989c5ccdb
8 changed files with 31 additions and 26 deletions
Download patch file Download diff file Expand all files Collapse all files

10
nix/agent-modules/queue.nix
View file

@ -38,10 +38,10 @@ in
which is the bridge address rather than a loopback one — inside this
container `127.0.0.1` is the agent itself.
`null` means this hive has no queue, and the harness then declares no
credential and logs that it has none. It is deliberately not defaulted
to anything: a guessed address builds fine and talks to the wrong
machine.
`null` means this hive has not been given the queue's address for its
agents, and the harness then declares no credential and logs that it
has none. It is deliberately not defaulted to anything: a guessed
address builds fine and talks to the wrong machine.
'';
};
@ -56,7 +56,7 @@ in
Set together with {option}`hyperhive.queue.natsUrl` or not at all —
the harness treats a half-set pair as a deployment bug rather than as
"no queue".
"no queue coordinates".
'';
};
};

3
nix/host-modules/swarm.nix
View file

@ -611,7 +611,8 @@ in
interface alone. ⚠️ Never a loopback address — inside an agent's network
namespace `127.0.0.1` is the agent, not this host.
Null means this hive's agents have no queue. Together with
Null means this hive's agents have not been given the queue's address.
Together with
{option}`services.hyperhive.swarm.statusPublish.tokenEndpoint` it is
what decides whether the harness is handed queue coordinates at all; a
hive whose queue is elsewhere names the address its containers route to.

15
nix/module-eval.nix
View file

@ -1278,7 +1278,8 @@ let
}
{
# The agents mint against the swarm's IdP, the same endpoint the hive's
# own client uses — a hive-local guess would be a token no queue accepts.
# own client uses — a hive-local guess would produce a token the queue
# would not accept.
name = "the agents' token endpoint is the swarm IdP's";
ok =
let
@ -1289,8 +1290,9 @@ let
}
{
# The absence arm, and what makes the two above able to fail: a hive
# with no queue must forward neither coordinate, because half a pair
# reaches the harness as a partial configuration rather than as none.
# with no queue address must forward neither coordinate, because half a
# pair reaches the harness as a partial configuration rather than as
# none.
name = "a hive with no swarm queue forwards no agent queue coordinates";
ok =
let
@ -1321,9 +1323,10 @@ let
&& e.HIVE_AGENT_OIDC_CLIENT_ID_FILE == "%d/hive-queue-agent-client-id";
}
{
# An agent built before its hive had a queue. It must declare nothing
# rather than name a credential that never arrives — and the harness
# then reports "no queue" instead of a half-set environment.
# An agent built before its hive was handed the queue's address. It
# must declare nothing rather than name a credential that never
# arrives — and the harness then reports "no queue coordinates"
# instead of a half-set environment.
name = "an agent with no queue coordinates declares no credential";
ok =
let