approve a requested review when the repo has no review rules
On deploy: a review requested of the review classifier on a PR whose repo holds neither .hyperhive/review-classifier.yml nor .json on its default branch now posts an APPROVED review at once, saying no review rules are configured for the repo and it was approved without checks. No model call is made. Before, that case posted a "No verdict" comment. A rules file that exists but fails to load or parse still posts no verdict. The rule model is unchanged and instance-wide: every repo without a rules file is approved.
This commit is contained in:
parent
0b1669a364
commit
26c4ff89d5
3 changed files with 111 additions and 19 deletions
|
|
@ -18,7 +18,7 @@ that reviewer.
|
|||
|
||||
## Repo configuration
|
||||
|
||||
A repo opts in with a rules file at its root, in YAML as
|
||||
A repo defines its rules in a file at its root, in YAML as
|
||||
`.hyperhive/review-classifier.yml` or in JSON as
|
||||
`.hyperhive/review-classifier.json`. It holds one of the two; with both, the
|
||||
rules don't load. `swarm-controller` always reads the file from the repo's
|
||||
|
|
@ -37,8 +37,14 @@ with exactly these four keys:
|
|||
|
||||
Any other key, at the top or in an entry, is an error: a misspelt key fails
|
||||
the load instead of vanishing. An empty list, more than ten entries, an empty
|
||||
name or description, and two entries with one name are errors too. Nothing
|
||||
falls back to a pass: a repo whose file doesn't load has no rules.
|
||||
name or description, and two entries with one name are errors too. A file
|
||||
that exists but fails these checks never falls back to a pass: the run posts
|
||||
no verdict.
|
||||
A repo whose default branch holds neither file has no rules. When someone
|
||||
requests the classifier's review on its PR, the account approves at once. The
|
||||
body reads `no review rules are configured for owner/name; approved without
|
||||
checks`. The controller makes no model call. The instance has no per-repo
|
||||
filter yet, so every repo without a rules file gets this approval.
|
||||
|
||||
An example:
|
||||
|
||||
|
|
@ -421,7 +427,8 @@ Repos that rely on it typically raise their required approval count to
|
|||
account for it.
|
||||
|
||||
A run with no clean verdict never approves. When the PR or the rules don't
|
||||
load, the run fails, the classifier answers a different number of
|
||||
load (a repo with no rules file gets an approval instead), the run fails, the classifier
|
||||
answers a different number of
|
||||
classifications than the controller sent it, or **any** classification has no answer,
|
||||
the account posts a **comment** instead, starting with `**No verdict:**` and the reason,
|
||||
followed by the table when there is one. A comment neither approves nor
|
||||
|
|
|
|||
Loading…
Reference in a new issue