CI and devshell comments say what the config does: jobTimeout bounds jobs, coverage runs nightly, dead timeout keys removed
Job-level timeout-minutes is parsed but not enforced by this runner; only the runner's jobTimeout bounds a job. Also fixes the devshell coverage comment, the shellcheck job comment, an option description citing a script that is not in the repo, and comment file pointers that resolve to nothing.
This commit is contained in:
parent
fefc565794
commit
2644c0d5f9
7 changed files with 20 additions and 27 deletions
|
|
@ -7,14 +7,14 @@ on:
|
|||
# Lets `hive-forge ci-rerun` re-trigger CI via workflow-dispatch API
|
||||
workflow_dispatch:
|
||||
|
||||
# No job sets `timeout-minutes`: this runner parses a job-level key but does not
|
||||
# enforce it. The runner's `services.hyperhive.deploy.ci-runner.jobTimeout`
|
||||
# (default 1h) is the only bound on how long a job runs.
|
||||
jobs:
|
||||
check:
|
||||
name: nix flake check
|
||||
if: vars.PUBLIC_FORGE != 'true'
|
||||
runs-on: ${{ vars.PUBLIC_FORGE == 'true' && 'nixos' || 'hive-ci' }}
|
||||
# 30 min is well above a cold-cache rebuild (~15 min observed) and well
|
||||
# under the runner's 3h cap
|
||||
timeout-minutes: 30
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
- name: check
|
||||
|
|
@ -24,7 +24,6 @@ jobs:
|
|||
name: tracker-tag lint
|
||||
if: vars.PUBLIC_FORGE != 'true'
|
||||
runs-on: ${{ vars.PUBLIC_FORGE == 'true' && 'nixos' || 'hive-ci' }}
|
||||
timeout-minutes: 5
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
- name: lint
|
||||
|
|
@ -34,7 +33,6 @@ jobs:
|
|||
name: comment-block lint
|
||||
if: vars.PUBLIC_FORGE != 'true'
|
||||
runs-on: ${{ vars.PUBLIC_FORGE == 'true' && 'nixos' || 'hive-ci' }}
|
||||
timeout-minutes: 5
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
- name: lint
|
||||
|
|
@ -44,7 +42,6 @@ jobs:
|
|||
name: doc-pointer lint
|
||||
if: vars.PUBLIC_FORGE != 'true'
|
||||
runs-on: ${{ vars.PUBLIC_FORGE == 'true' && 'nixos' || 'hive-ci' }}
|
||||
timeout-minutes: 5
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
- name: lint
|
||||
|
|
@ -54,7 +51,6 @@ jobs:
|
|||
name: attribution-trailer lint
|
||||
if: vars.PUBLIC_FORGE != 'true'
|
||||
runs-on: ${{ vars.PUBLIC_FORGE == 'true' && 'nixos' || 'hive-ci' }}
|
||||
timeout-minutes: 5
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
with:
|
||||
|
|
@ -66,22 +62,23 @@ jobs:
|
|||
name: dashboard-description lint
|
||||
if: vars.PUBLIC_FORGE != 'true'
|
||||
runs-on: ${{ vars.PUBLIC_FORGE == 'true' && 'nixos' || 'hive-ci' }}
|
||||
timeout-minutes: 5
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
- name: lint
|
||||
# jq isn't a project dependency elsewhere in this repo — same
|
||||
# nix-shell-for-one-tool shape the vale/shellcheck jobs above use.
|
||||
# nix-shell-for-one-tool shape the vale jobs below use.
|
||||
run: nix shell nixpkgs#jq --command sh scripts/check-dashboard-descriptions.sh
|
||||
|
||||
shellcheck:
|
||||
name: shellcheck
|
||||
if: vars.PUBLIC_FORGE != 'true'
|
||||
runs-on: ${{ vars.PUBLIC_FORGE == 'true' && 'nixos' || 'hive-ci' }}
|
||||
timeout-minutes: 10
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
- name: lint
|
||||
# `nix develop` enters the whole devshell for this one tool, which pins
|
||||
# shellcheck to flake.lock; the vale and jq jobs take theirs from the registry.
|
||||
#
|
||||
# By shebang, not a `*.sh` glob — scripts/pre-push has no suffix.
|
||||
run: |
|
||||
files=$(grep -lE '^#!.*/(env[[:space:]]+)?(ba)?sh([[:space:]]|$)' scripts/* 2>/dev/null)
|
||||
|
|
@ -95,7 +92,6 @@ jobs:
|
|||
name: prose lint (vale)
|
||||
if: vars.PUBLIC_FORGE != 'true'
|
||||
runs-on: ${{ vars.PUBLIC_FORGE == 'true' && 'nixos' || 'hive-ci' }}
|
||||
timeout-minutes: 5
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
- name: lint
|
||||
|
|
@ -108,7 +104,6 @@ jobs:
|
|||
name: prose lint (vale, errors)
|
||||
if: vars.PUBLIC_FORGE != 'true'
|
||||
runs-on: ${{ vars.PUBLIC_FORGE == 'true' && 'nixos' || 'hive-ci' }}
|
||||
timeout-minutes: 5
|
||||
steps:
|
||||
- uses: actions/checkout@v3
|
||||
- name: lint
|
||||
|
|
|
|||
Loading…
Reference in a new issue