vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

address review: drop stale ask/answer refs from the messaging tool group + a comment

Browse source
This commit is contained in:
damocles 2026-08-29 21:05:51 +02:00 • committed by mara
commit 1c4d662cf1
3 changed files with 6 additions and 6 deletions
Download patch file Download diff file Expand all files Collapse all files

2
docs/conventions.md
View file

@ -348,7 +348,7 @@ binary flavor.
| Group | Tools | | Group | Tools |
|---|---| |---|---|
| `messaging` | `send`, `recv`, `ack_until`, `ask`, `answer` | | `messaging` | `send`, `recv`, `ack_until` |
| `meta` | `get_agent_meta` (`set_status` is always-on, see below) | | `meta` | `get_agent_meta` (`set_status` is always-on, see below) |
| `inbox` | `get_loose_ends`, `cancel_loose_end`, `remind` | | `inbox` | `get_loose_ends`, `cancel_loose_end`, `remind` |
| `execution` | vestigial — `mcp__bash__run` / `mcp__bash__status` are always available unconditionally via `extraMcpServers`; this group's entries expand to non-existent `mcp__hyperhive__run` / `mcp__hyperhive__status` and have no effect. See `docs/tools/bash.md`. | | `execution` | vestigial — `mcp__bash__run` / `mcp__bash__status` are always available unconditionally via `extraMcpServers`; this group's entries expand to non-existent `mcp__hyperhive__run` / `mcp__hyperhive__status` and have no effect. See `docs/tools/bash.md`. |

4
hive-agent-mcp/src/mcp/mod.rs
View file

@ -433,8 +433,8 @@ impl AgentServer {
// the c0re side, so a successful cancel here always means // the c0re side, so a successful cancel here always means
// *this* agent's own `asked` mirror row for `id`. Known gap // *this* agent's own `asked` mirror row for `id`. Known gap
// (documented on `Questions`): the target isn't notified, // (documented on `Questions`): the target isn't notified,
// so their `answering` row lingers until they call // so their `answering` row always lingers until it goes
// `answer()` or it goes stale. // stale — `answer()` no longer exists as an option.
let _ = dial_agent_socket(&hive_agent_sock::Request::ClearQuestion { id }).await; let _ = dial_agent_socket(&hive_agent_sock::Request::ClearQuestion { id }).await;
} }
annotate_retries( annotate_retries(

6
hive-sh4re/src/permissions.rs
View file

@ -15,7 +15,7 @@ use serde::{Deserialize, Serialize};
#[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)] #[derive(Debug, Clone, Copy, PartialEq, Eq, Hash, Serialize, Deserialize)]
#[serde(rename_all = "snake_case")] #[serde(rename_all = "snake_case")]
pub enum ToolGroup { pub enum ToolGroup {
/// `send`, `recv`, `ask`, `answer` /// `send`, `recv`, `ack_until`
Messaging, Messaging,
/// `get_agent_meta` (`set_status` is always-on — see `ALWAYS_ON_TOOLS`) /// `get_agent_meta` (`set_status` is always-on — see `ALWAYS_ON_TOOLS`)
Meta, Meta,
@ -51,7 +51,7 @@ impl ToolGroup {
#[must_use] #[must_use]
pub fn tools(self) -> &'static [&'static str] { pub fn tools(self) -> &'static [&'static str] {
match self { match self {
Self::Messaging => &["send", "recv", "ack_until", "ask", "answer"], Self::Messaging => &["send", "recv", "ack_until"],
Self::Meta => &["get_agent_meta"], Self::Meta => &["get_agent_meta"],
Self::Inbox => &["get_loose_ends", "cancel_loose_end", "remind"], Self::Inbox => &["get_loose_ends", "cancel_loose_end", "remind"],
Self::Lifecycle => &["kill", "start", "restart", "update", "list_containers"], Self::Lifecycle => &["kill", "start", "restart", "update", "list_containers"],
@ -163,7 +163,7 @@ impl ToolGroup {
#[must_use] #[must_use]
pub fn description(self) -> &'static str { pub fn description(self) -> &'static str {
match self { match self {
Self::Messaging => "send, recv, ask, answer — core agent communication", Self::Messaging => "send, recv, ack_until — core agent communication",
Self::Meta => { Self::Meta => {
"get_agent_meta — identity introspection (set_status is always available)" "get_agent_meta — identity introspection (set_status is always available)"
} }