vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

review classifier: run on ACP when the swarm settings choose it

Browse source 
The swarm settings gain `runtime` (`api-key`, the default, or `acp`) and
an `acp` provider record: an https base URL, the provider's model, and
its prices per million tokens. A PUT now changes only the fields its
body names, so the settings form that sends model, effort and limit
leaves the runtime alone; `null` clears `effort` or `acp`. The body stays
strict, and the stored document keeps #5192's lenient read.

The controller sends the runtime in each run request. On `acp` the
classifier runs one prompt on a new `opencode acp` session per
classification through hive-runtime's AcpRuntime, in a scratch
directory, with a config rendered from the settings. opencode runs
`read` and other tools without asking, so OPENCODE_PERMISSION
{"*":"deny"} takes every tool away from the model, and a deny-all policy
refuses any request on top. The title call, which resends the prompt,
is turned off. The deadline cancels the turn, and a turn that does not
end within 15s of that is dropped, which also covers an agent stuck
before its prompt. The answer is the final assistant text, as ACP has
no result event.

The provider key is read per run from
swarm/services/review-classifier/acp-provider, which the bao UI's
admins login may create and update, and reaches opencode through
AcpRuntime::with_provider_key and the trampoline's allowlist.

Each ACP classification's cost is computed from the configured prices
and the reported tokens, and added to
hyperhive.review_classifier.cost.usage labelled repo, pr, model and
currency.

Part of #5096
This commit is contained in:
atlas 2026-10-13 10:15:27 +02:00 • committed by mara
commit 1b4e764e5c
24 changed files with 1622 additions and 262 deletions
Download patch file Download diff file Expand all files Collapse all files

20
swarm-controller/src/review_classifier.rs
View file

@ -638,6 +638,9 @@ async fn start(
settings: Settings,
) -> Result<(StatusCode, Json<TryOutAccepted>), ProblemDetails> {
let started_unix = crate::agent_renewal::unix_now();
let runtime = settings
.runtime()
.map_err(|e| error_problem(StatusCode::INTERNAL_SERVER_ERROR, &e))?;
let repo = format!("{}/{}", run.owner, run.name);
let pull =
forge::within_forge_deadline("review try-out", pulls.pull(&run.owner, &run.name, run.pr))
@ -659,6 +662,7 @@ async fn start(
classifications: run.classifications,
model: settings.model,
effort: settings.effort,
runtime,
};
let payload = serde_json::to_vec(&request).map_err(|e| {
error_problem(
@ -940,15 +944,28 @@ pub(crate) mod tests {
}
#[tokio::test]
async fn a_try_out_runs_on_the_stored_model_and_effort() {
async fn a_try_out_runs_on_the_stored_runtime_model_and_effort() {
use swarm_queue_client::agent_inference::Effort;
use swarm_queue_client::review_classifier::Runtime;
let acp = swarm_queue_client::review_classifier::Acp {
base_url: "https://llm.example/v1".to_owned(),
model: "qwen".to_owned(),
prices: swarm_queue_client::review_classifier::Prices {
input: 1.0,
output: 2.0,
cache_read: None,
cache_write: None,
},
};
let (mut state, _) = crate::tests::state_with_roster();
let fake = Arc::new(Fake {
settings: Settings {
model: "opus".to_owned(),
effort: Some(Effort::High),
max_concurrent_reviews: 2,
runtime: settings::RuntimeKind::Acp,
acp: Some(acp.clone()),
},
..Fake::new(done(), Vec::new())
});
@ -963,6 +980,7 @@ pub(crate) mod tests {
(sent[0].model.as_str(), sent[0].effort),
("opus", Some(Effort::High))
);
assert_eq!(sent[0].runtime, Runtime::Acp(acp));
}
#[tokio::test]