vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

hive-forge: remove pr-blocked-by-issue hint now that the direction works

Browse source
This commit is contained in:
damocles 2026-09-02 08:59:35 +02:00 • committed by mara
commit 16f82f3ef6
1 changed files with 1 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

37
hive-forge/src/verbs/dependency.rs
View file

@ -17,7 +17,7 @@ use forgejo_api::structs::IssueMeta;
use serde_json::Value;
use crate::client::{Client, index};
use crate::verbs::{dependency_summaries, is_pr, print_json};
use crate::verbs::{dependency_summaries, print_json};
#[derive(ClapArgs)]
pub struct Args {
@ -152,10 +152,6 @@ fn apply_and_verify(
"hive-forge: warning: dependency on #{dep} converged despite a reported \
error (server-side issue after the write, not a real failure): {e:#}"
);
} else if let Some(hint) =
pr_blocked_by_issue_hint(client, owner, name, number, dep, adding)
{
real_failures.push(format!("#{dep}: {e:#}\n {hint}"));
} else {
real_failures.push(format!("#{dep}: {e:#}"));
}
@ -172,37 +168,6 @@ fn apply_and_verify(
Ok(())
}
/// A hint appended to a genuine add-failure when it matches the one known
/// unsupported shape: a **PR** depending on a plain **issue**.
///
/// Confirmed via the full four-way matrix against the live forge:
/// issue→issue and issue→PR both work, PR→issue 500s every time with the
/// edge genuinely absent on read-back. `hive-forge`'s own request is
/// identical across all four directions, so this is an upstream Forgejo
/// limitation, not a bug this client can route around — there is no other
/// side to add the edge from. Best-effort: the two extra classification
/// GETs are swallowed on error rather than obscuring the real failure with
/// a diagnostic-aid failure.
fn pr_blocked_by_issue_hint(
client: &Client,
owner: &str,
name: &str,
number: u64,
dep: u64,
adding: bool,
) -> Option<&'static str> {
if !adding {
return None;
}
let source_is_pr = is_pr(client, owner, name, number).ok()?;
let target_is_pr = is_pr(client, owner, name, dep).ok()?;
(source_is_pr && !target_is_pr).then_some(
"known limitation: a PR cannot be marked as depending on a plain issue (an upstream \
Forgejo limitation, not a hive-forge bug). Record the hold as prose in the PR \
body/comment instead; there's no dependency-edge mechanism for this direction.",
)
}
/// Build the `IssueMeta` body the create/remove endpoints want.
///
/// `owner`/`repo` are filled in with the *same* repo the request URL