hive-forge: page past the forge's 50-row clamp; show list --json truncation
The forge clamps page_size to 50. branches, pr reviews, the review bodies merged into `comments <pr>`, and view's comment list each sent one request, so anything past the first page was dropped silently. labels::repo_labels did loop, but asked for 100/page and stopped on `len < 100`, so a clamped full page of 50 ended the walk. Add verbs::all_pages: requests 50/page until a short page, capped at 50 pages with a stderr warning when the cap is hit. Use it in all of the above; repo-labels now calls labels::repo_labels instead of its own copy of the loop. list --json now prints the same "N of M shown" stderr trailer as the pretty output; its paging and stdout shape are unchanged. Closes #5051
This commit is contained in:
parent
52f589780f
commit
0e5c61d12c
9 changed files with 164 additions and 90 deletions
|
|
@ -4,7 +4,7 @@ use anyhow::Result;
|
|||
use clap::Args as ClapArgs;
|
||||
|
||||
use crate::client::Client;
|
||||
use crate::verbs::refuse_json;
|
||||
use crate::verbs::{all_pages, refuse_json};
|
||||
|
||||
#[derive(ClapArgs)]
|
||||
pub struct Args {
|
||||
|
|
@ -15,11 +15,15 @@ pub struct Args {
|
|||
pub fn run(client: &Client, args: Args) -> Result<()> {
|
||||
refuse_json(client.json_mode(), "branches", "only the plain name list")?;
|
||||
let (owner, name) = client.owner_repo()?;
|
||||
let (_, branches) = client
|
||||
.api()
|
||||
.repo_list_branches(owner, name)
|
||||
.page_size(100)
|
||||
.send()?;
|
||||
let branches = all_pages(|page, size| {
|
||||
let (_, batch) = client
|
||||
.api()
|
||||
.repo_list_branches(owner, name)
|
||||
.page(page)
|
||||
.page_size(size)
|
||||
.send()?;
|
||||
Ok(batch)
|
||||
})?;
|
||||
for branch in &branches {
|
||||
let Some(n) = branch.name.as_deref() else {
|
||||
continue;
|
||||
|
|
|
|||
Loading…
Reference in a new issue