vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

fix(frontend): flag gone-agent columns in the schedules table (#1586)

Browse source 
The schedules table builds a column per target, including agents that
have since been destroyed (their past schedules linger). Those columns
showed identically to live agents, so the operator couldn't tell a
schedule still targets something that no longer exists.

Flag them: renderSchedulesTableHead now checks each agent column against
the live roster (containersState) and, for any that isn't there (and
isn't 'operator', which is always valid), greys + strikes through the
column label and titles it 'no longer exists (gone)'. The rows stay
visible + cancellable — the operator can see the stale targets and clear
them rather than be surprised by phantom columns. Build green.
This commit is contained in:
iris 2026-06-10 00:55:28 +02:00 • committed by mara
commit 0dc85e8261
2 changed files with 17 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

8
frontend/packages/dashboard/src/dashboard.css
View file

@ -1181,6 +1181,14 @@ footer .banner-thin {
display: inline-block;
padding: 0 4px 1px;
}
/* Column for an agent no longer in the live roster — its past schedules
linger but the agent is gone. Greyed + struck through so the operator
can still see (and cancel) the stale entries rather than be surprised. */
.schedules-table-agent-th--gone > div {
color: var(--muted);
text-decoration: line-through;
opacity: 0.75;
}
.schedules-table-row-cancelled td { opacity: 0.55; }
.schedules-table-body-cell {
max-width: 30em;

11
frontend/packages/dashboard/src/schedules.js
View file

@ -619,9 +619,16 @@ function renderSchedulesTableHead(agents) {
el('th', {}, 'owner'),
el('th', { class: 'schedules-table-body-th' }, 'body'),
);
// 'operator' is always a valid target; every other column maps to a
// container, so flag any column whose agent is no longer in the live
// roster — its past schedules linger in the table but the agent is gone.
const liveNames = new Set(Array.from(containersState.values()).map((c) => c.name));
for (const a of agents) {
headerRow.append(el('th', { class: 'schedules-table-agent-th', title: a },
el('div', {}, el('span', {}, a))));
const gone = a !== 'operator' && !liveNames.has(a);
headerRow.append(el('th', {
class: 'schedules-table-agent-th' + (gone ? ' schedules-table-agent-th--gone' : ''),
title: gone ? a + ' — no longer exists (gone)' : a,
}, el('div', {}, el('span', {}, a))));
}
headerRow.append(el('th', { class: 'schedules-table-actions-th' }, ''));
thead.append(headerRow);