From 0bdee751b973235d498d90fbe8c367b3b59d3938 Mon Sep 17 00:00:00 2001 From: atlas Date: Sun, 13 Sep 2026 15:15:38 +0200 Subject: [PATCH] subagent daemon: address review on the killed-session docs argus's review on #4333 flagged one real vale error (Microsoft.Contractions): "did not" in the new "A killed turn" section reads as "didn't" instead. The rest of the diff's new prose (docs/tools/subagent.md and the tool descriptions in hive-subagent-mcp/src/mcp.rs) has no other instance of the same expansion, confirmed both by a local `vale --minAlertLevel=error` run (clean) and by grepping the added lines. Also tidies session.rs's module doc: the two `//!` runs split to dodge the 30-line comment-block lint had a bare trailing `//!` right before the blank separator; dropped so the first run ends on content. Refs #4326 --- docs/tools/subagent.md | 2 +- hive-subagent-mcp/src/session.rs | 1 - 2 files changed, 1 insertion(+), 2 deletions(-) diff --git a/docs/tools/subagent.md b/docs/tools/subagent.md index 82ae25ec..23d67ebf 100644 --- a/docs/tools/subagent.md +++ b/docs/tools/subagent.md @@ -37,7 +37,7 @@ restart loses the _in-flight turn_, not the subagent's history. A subagent whose `claude` process dies on a signal — the kernel's OOM killer under memory pressure, a stopped unit, an `interrupt` from the -owning agent — did not finish its turn, and the daemon says so rather +owning agent — didn't finish its turn, and the daemon says so rather than letting it settle back into `idle`: - `status` reports the session **killed**, naming the signal, instead of diff --git a/hive-subagent-mcp/src/session.rs b/hive-subagent-mcp/src/session.rs index fdf6cf4b..bc6bc9bf 100644 --- a/hive-subagent-mcp/src/session.rs +++ b/hive-subagent-mcp/src/session.rs @@ -15,7 +15,6 @@ //! reattaches to it, whether that's "give it a new turn" or "the daemon //! restarted and I want to pick this back up" — after a restart, re-supply //! `dir` once if the session isn't in the daemon's own default directory. -//! //! **A killed turn is not a finished turn.** A child that died on a signal //! arrives as a `hive_claude::Error::Exit` carrying its `ExitStatus`, so the