archetypes: reviewer holds execution so it can run hive-forge and git
The reviewer now has messaging, inbox and execution. execution is what gives an agent the bash server, without which it cannot run hive-forge or git to read a PR and post a review. meta is dropped: get_agent_meta is not part of reviewing a PR. Refs #5386
This commit is contained in:
parent
51035eac1d
commit
0382c65386
3 changed files with 11 additions and 9 deletions
|
|
@ -126,7 +126,7 @@ let
|
|||
# output and prints it as JSON. A derivation or a path in `meta` would
|
||||
# make that evaluation build or copy something; a function would not
|
||||
# print at all.
|
||||
name = "the built-in archetypes carry a module and a meta of plain data, and reviewer has no shell";
|
||||
name = "the built-in archetypes carry a module and a meta of plain data, and reviewer can run commands";
|
||||
ok =
|
||||
let
|
||||
plain =
|
||||
|
|
@ -146,7 +146,9 @@ let
|
|||
lib.all (a: a ? module && a.meta.description != "") (lib.attrValues archetypes)
|
||||
&& plain metas
|
||||
&& lib.elem "messaging" reviewer
|
||||
&& !(lib.elem "execution" reviewer);
|
||||
&& lib.elem "inbox" reviewer
|
||||
&& lib.elem "execution" reviewer
|
||||
&& !(lib.elem "meta" reviewer);
|
||||
}
|
||||
{
|
||||
# The responder denies a client id it does not know, and a NATS denial
|
||||
|
|
|
|||
Loading…
Reference in a new issue