vinzenz/hyperhive
vinzenz/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1

refactor(#1896): remove dead forge_notify reason plumbing + fix docs

Browse source
This commit is contained in:
damocles 2026-06-23 14:44:25 +02:00 • committed by mara
commit 00f682991c
2 changed files with 21 additions and 52 deletions
Download patch file Download diff file Expand all files Collapse all files

30
docs/forge.md
View file

@ -129,16 +129,16 @@ best-effort: logged at debug/warn and retried next tick.
Forgejo fires notifications for the agent's own actions (it opened a Forgejo fires notifications for the agent's own actions (it opened a
PR, posted a comment, submitted a review). Surfacing those would PR, posted a comment, submitted a review). Surfacing those would
loop claude on its own writes. Two filter rules drop them silently loop claude on its own writes. The comment/review case is dropped
(mark-read without delivery): silently (mark-read without delivery):
- **Self-authored new items** — notifications with
`reason == "author"` AND subject state `open` (or missing). State
transitions (merge / close) on the agent's own PRs DO surface,
since those are triggered by someone else.
- **Self-authored comments / reviews** — comment payload's - **Self-authored comments / reviews** — comment payload's
`user.login` matches `own_login`. `user.login` matches `own_login`.
Self-authored *new items* (an agent opening its own PR/issue) are not
filtered and do surface — the notification subject carries no author
field to match against without a per-notification fetch.
`own_login` is fetched once at startup via `GET /api/v1/user`. On `own_login` is fetched once at startup via `GET /api/v1/user`. On
fetch failure the filter degrades open (no filtering) rather than fetch failure the filter degrades open (no filtering) rather than
crashing the task — a noisy inbox beats a silently-stuck poller. crashing the task — a noisy inbox beats a silently-stuck poller.
@ -181,11 +181,11 @@ Five shapes, distinguished by the notification's classification:
| Trigger | Wrapper | | Trigger | Wrapper |
| --- | --- | | --- | --- |
| Comment on issue / PR | `[comment on PR #N owner/repo] title\nurl: ...\n\nauthor: body\nassignee: ...\nreason: mention` | | Comment on issue / PR | `[comment on PR #N owner/repo] title\nurl: ...\n\nauthor: body\nassignee: ...` |
| Review submission | `[PR approved #N owner/repo] title\nurl: ...\n\nreviewer: body\nassignee: ...\nreason: review_requested` | | Review submission | `[PR approved #N owner/repo] title\nurl: ...\n\nreviewer: body\nassignee: ...` |
| New issue / PR | `[new PR #N owner/repo] title\nurl: ...\n\n<body excerpt>\nassignee: ...\nreason: subscribed` | | New issue / PR | `[new PR #N owner/repo] title\nurl: ...\n\n<body excerpt>\nassignee: ...` |
| Later activity (open, not creation) | `[activity on PR #N owner/repo] title\nurl: ...\n\n<body excerpt>\nassignee: ...\nreason: subscribed` | | Later activity (open, not creation) | `[activity on PR #N owner/repo] title\nurl: ...\n\n<body excerpt>\nassignee: ...` |
| State change | `[PR merged #N owner/repo] title\nurl: ...\nassignee: ...\nreason: subscribed` | | State change | `[PR merged #N owner/repo] title\nurl: ...\nassignee: ...` |
Review labels come from the Forgejo `state` field: `APPROVED` → Review labels come from the Forgejo `state` field: `APPROVED` →
`approved`, `REQUEST_CHANGES` → `changes requested`, `COMMENT` → `approved`, `REQUEST_CHANGES` → `changes requested`, `COMMENT` →
@ -222,14 +222,6 @@ Every wrapper ends with one or more of:
the line shape is stable. the line shape is stable.
- `reviewer: <list>` — PR notifications only, present only when - `reviewer: <list>` — PR notifications only, present only when
`requested_reviewers` is non-empty. `requested_reviewers` is non-empty.
- `reason: <forgejo-reason>` — always present when the notification
carries a reason; absent when the field is null/missing.
The `reason` line distinguishes otherwise-identical messages: Forgejo
emits one notification per applicable reason for the same event
(e.g. both `mention` and `subscribed` arrive for a PR comment that
tags the agent). Without the suffix, the agent would see duplicated
wrapper text with no signal which Forgejo path triggered each copy.
### Review-request override ### Review-request override

43
hive-ag3nt/src/forge_notify.rs
View file

@ -382,8 +382,7 @@ async fn format_notification(
}; };
let is_pr = matches!(notif_type, "Pull Request" | "Pull"); let is_pr = matches!(notif_type, "Pull Request" | "Pull");
let reason = notif["reason"].as_str().unwrap_or(""); let meta_suffix = build_meta_suffix(subject.as_ref(), is_pr);
let meta_suffix = build_meta_suffix(subject.as_ref(), is_pr, reason);
// Determine whether this notification was triggered by a comment/review or // Determine whether this notification was triggered by a comment/review or
// by creation/state-change of the subject itself. // by creation/state-change of the subject itself.
@ -396,7 +395,6 @@ async fn format_notification(
num, num,
repo, repo,
meta_suffix, meta_suffix,
reason,
subject, subject,
is_pr, is_pr,
}; };
@ -411,7 +409,7 @@ async fn format_notification(
) )
.await .await
} else { } else {
format_state_change_notification(notif, &meta, own_login) Some(format_state_change_notification(notif, &meta, own_login))
} }
} }
@ -423,19 +421,15 @@ struct NotifMeta<'a> {
num: String, num: String,
repo: String, repo: String,
meta_suffix: String, meta_suffix: String,
/// Forgejo `reason` value (e.g. "mention", "assigned", "subscribed").
/// Appended to every wrapper as the `reason:` line in the meta
/// suffix (see `docs/forge.md::Meta suffix`).
reason: &'a str,
/// Fetched subject detail (issue/PR JSON); used for review-request detection. /// Fetched subject detail (issue/PR JSON); used for review-request detection.
subject: Option<serde_json::Value>, subject: Option<serde_json::Value>,
is_pr: bool, is_pr: bool,
} }
/// Build the `\nassignee: ...` (and optionally `\nreviewer: ...` and /// Build the `\nassignee: ...` (and optionally `\nreviewer: ...`)
/// `\nreason: ...`) suffix appended to every wrapper. Shape + /// suffix appended to every wrapper. Shape + presence rules live in
/// presence rules live in `docs/forge.md::Meta suffix`. /// `docs/forge.md::Meta suffix`.
fn build_meta_suffix(subject: Option<&serde_json::Value>, is_pr: bool, reason: &str) -> String { fn build_meta_suffix(subject: Option<&serde_json::Value>, is_pr: bool) -> String {
let assignees: Vec<&str> = subject let assignees: Vec<&str> = subject
.and_then(|s| s["assignees"].as_array()) .and_then(|s| s["assignees"].as_array())
.map(|arr| arr.iter().filter_map(|a| a["login"].as_str()).collect()) .map(|arr| arr.iter().filter_map(|a| a["login"].as_str()).collect())
@ -459,21 +453,10 @@ fn build_meta_suffix(subject: Option<&serde_json::Value>, is_pr: bool, reason: &
} else { } else {
None None
}; };
// Always include reason so multiple notifications for the same
// event (each with a different Forgejo reason) stay
// distinguishable.
let reason_line = if reason.is_empty() {
None
} else {
Some(format!("reason: {reason}"))
};
let mut out = format!("\n{assignee_line}"); let mut out = format!("\n{assignee_line}");
if let Some(r) = reviewer_line { if let Some(r) = reviewer_line {
write!(out, "\n{r}").ok(); write!(out, "\n{r}").ok();
} }
if let Some(r) = reason_line {
write!(out, "\n{r}").ok();
}
out out
} }
@ -574,7 +557,7 @@ fn format_state_change_notification(
notif: &serde_json::Value, notif: &serde_json::Value,
meta: &NotifMeta<'_>, meta: &NotifMeta<'_>,
own_login: &str, own_login: &str,
) -> Option<String> { ) -> String {
// Classification uses notif["subject"]["state"] directly — Forgejo // Classification uses notif["subject"]["state"] directly — Forgejo
// returns "open" / "closed" / "merged" here. We do NOT rely on // returns "open" / "closed" / "merged" here. We do NOT rely on
// fetching the PR/issue detail for `merged`: // fetching the PR/issue detail for `merged`:
@ -583,14 +566,9 @@ fn format_state_change_notification(
// - Forgejo API type is "Pull" / "Issue", never "Pull Request". // - Forgejo API type is "Pull" / "Issue", never "Pull Request".
let notif_state = notif["subject"]["state"].as_str().unwrap_or(""); let notif_state = notif["subject"]["state"].as_str().unwrap_or("");
// Self-notification filter: drop new items we authored ourselves // "New" = the subject is open (or state is absent). Used below for
// (`reason == "author"` + open state). State transitions on our // the review-request override.
// own PRs (merge / close) come from someone else, so those stay.
let is_new = notif_state == "open" || notif_state.is_empty(); let is_new = notif_state == "open" || notif_state.is_empty();
if is_new && meta.reason == "author" && !own_login.is_empty() {
debug!(%own_login, "forge_notify: skipping self-authored new item");
return None;
}
let NotifMeta { let NotifMeta {
title, title,
@ -599,7 +577,6 @@ fn format_state_change_notification(
num, num,
repo, repo,
meta_suffix, meta_suffix,
reason: _,
subject, subject,
is_pr, is_pr,
} = meta; } = meta;
@ -658,7 +635,7 @@ fn format_state_change_notification(
let mut out = format!("[{kind}] {title}\nurl: {html_url}{body_block}"); let mut out = format!("[{kind}] {title}\nurl: {html_url}{body_block}");
out.push_str(meta_suffix); out.push_str(meta_suffix);
Some(out) out
} }
/// Decide whether a state-change notification represents the subject's /// Decide whether a state-change notification represents the subject's