atlas
96eda4ed6b
fix( #2375 ): pr_is_open state check at submission + atomic fetched_sha INSERT
...
Two hardening items from argus's review of #2374 :
1. PR state check at submission:
- Add `pr_is_open(repo, pr)` to forge/pr_merge.rs using
`repo_get_pull_request` + `StateType` — early error if the PR is
already closed or merged instead of queuing a card that fails later
- Call it in `submit_merge_config_pr` before fetching the head sha
2. Atomic fetched_sha INSERT:
- Add `fetched_sha: Option<&str>` to `Approvals::submit_kind` so
the sha can be included in the INSERT rather than a follow-up UPDATE
- MergeConfigPr already knows the sha before inserting the row
(pr_head_sha runs first) → pass `Some(&sha)`, drop the separate
`set_fetched_sha` call → truly atomic
- ApplyCommit still needs two writes (sha resolved by git_fetch_to_tag
after the row exists) → pass `None`, `set_fetched_sha` unchanged
- All other callers (InitConfig, Spawn, UpdateMetaInputs,
SchedulePrompt) pass `None` — no behavioural change
- Add `fetched_sha_in_insert_is_readable_via_get` test covering the
MergeConfigPr path
2026-07-11 12:19:52 +02:00
..
agent_config
refactor( #2285 ): inline remaining 1:1 path wrappers (meta_dir, marker fns, host_conf_path)
2026-07-10 20:32:03 +02:00
bin
docs( #1970 ): rewrite for UI-driven shape (github.enable + host switch), purge githubAccount refs, regen hivectl-cli.md
2026-07-11 12:18:55 +02:00
dashboard
fix( #2375 ): pr_is_open state check at submission + atomic fetched_sha INSERT
2026-07-11 12:19:52 +02:00
forge
fix( #2375 ): pr_is_open state check at submission + atomic fetched_sha INSERT
2026-07-11 12:19:52 +02:00
job_queue
refactor( #2285 ): inline remaining 1:1 path wrappers (meta_dir, marker fns, host_conf_path)
2026-07-10 20:32:03 +02:00
lifecycle
refactor( #2285 ): inline remaining 1:1 path wrappers (meta_dir, marker fns, host_conf_path)
2026-07-10 20:32:03 +02:00
socket_server
fix( #2375 ): pr_is_open state check at submission + atomic fetched_sha INSERT
2026-07-11 12:19:52 +02:00
stats
feat( #2289 ): debounced SweepHealth banner tracker, wire knowledge pull
2026-07-10 14:46:43 +02:00
stores
fix( #2375 ): pr_is_open state check at submission + atomic fetched_sha INSERT
2026-07-11 12:19:52 +02:00
workers
refactor( #2285 ): inline remaining 1:1 path wrappers (meta_dir, marker fns, host_conf_path)
2026-07-10 20:32:03 +02:00
actions.rs
refactor( #2285 ): drop coordinator 1:1 path accessors, callers use paths:: directly
2026-07-10 20:32:03 +02:00
client.rs
hive-c0re: admin socket server + client (stub dispatch)
2026-05-14 20:49:11 +02:00
container_view.rs
refactor( #2285 ): repoint all hive-c0re host-path consumers to paths.rs
2026-07-10 20:32:03 +02:00
coordinator.rs
refactor( #2285 ): drop coordinator 1:1 path accessors, callers use paths:: directly
2026-07-10 20:32:03 +02:00
dashboard_events.rs
feat(hive-c0re): replace rebuild queue with generic job-DAG queue
2026-07-06 20:36:57 +02:00
flake_check.rs
refactor( #2111 ): remove nixpkgs-unstable, source claude-code from main nixpkgs
2026-07-01 19:32:46 +02:00
gateway_nginx.rs
refactor( #2285 ): inline remaining 1:1 path wrappers (meta_dir, marker fns, host_conf_path)
2026-07-10 20:32:03 +02:00
lib.rs
feat( #2289 ): debounced SweepHealth banner tracker, wire knowledge pull
2026-07-10 14:46:43 +02:00
loose_ends.rs
style: import ordering + blank lines after now_unix sweep (treefmt)
2026-07-06 22:08:40 +02:00
main.rs
refactor( #2285 ): repoint all hive-c0re host-path consumers to paths.rs
2026-07-10 20:32:03 +02:00
matrix.rs
refactor( #2285 ): repoint all hive-c0re host-path consumers to paths.rs
2026-07-10 20:32:03 +02:00
meta.rs
feat( #1970 ): host services.hyperhive.github.enable (default true) + meta.rs propagation of the off-switch
2026-07-11 12:18:55 +02:00
migrate.rs
refactor( #2285 ): inline remaining 1:1 path wrappers (meta_dir, marker fns, host_conf_path)
2026-07-10 20:32:03 +02:00
paths.rs
fix( #2368 ): AGENT_RUNTIME_ROOT → priv_proto; fix stale priv comment; cross-ref lockstep
2026-07-11 01:22:50 +02:00
priv_client.rs
docs( #1970 ): rewrite for UI-driven shape (github.enable + host switch), purge githubAccount refs, regen hivectl-cli.md
2026-07-11 12:18:55 +02:00
questions.rs
refactor: drop kind_to_str wrapper, call ApprovalKind::as_str directly
2026-07-06 21:49:46 +02:00
server.rs
fix( #2375 ): pr_is_open state check at submission + atomic fetched_sha INSERT
2026-07-11 12:19:52 +02:00