atlas
7b1b1d9db8
fix( #2164 ): address argus review — Option<String> secret + stale hook cleanup
...
Two issues flagged by argus in PR #2388 review:
1. Empty-key fallback: when load_or_generate() failed, webhook_secret was
String::new(). An attacker knowing this could forge deliveries with a
valid HMAC of the empty key. Fix: change to Option<String>; on None,
skip hook registration entirely and return 503 from /webhook/* handlers
(rather than 401 with a misleadingly-verifiable empty-key HMAC).
2. Stale hook cleanup: on upgrade from old code, old loopback hooks
(http://127.0.0.1:.../webhook/knowledge , .../webhook/config-pr) were
left alongside the new domain-URL hook. Fix: during ensure_webhook /
ensure_config_pr_webhook, after listing hooks, delete any that end with
our path suffix but point at a different base URL.
clippy + nix fmt clean.
2026-07-12 02:21:33 +02:00
..
agent_config
refactor( #2285 ): inline remaining 1:1 path wrappers (meta_dir, marker fns, host_conf_path)
2026-07-10 20:32:03 +02:00
bin
docs( #1970 ): rewrite for UI-driven shape (github.enable + host switch), purge githubAccount refs, regen hivectl-cli.md
2026-07-11 12:18:55 +02:00
dashboard
fix( #2164 ): address argus review — Option<String> secret + stale hook cleanup
2026-07-12 02:21:33 +02:00
forge
fix( #2164 ): address argus review — Option<String> secret + stale hook cleanup
2026-07-12 02:21:33 +02:00
job_queue
refactor( #2285 ): inline remaining 1:1 path wrappers (meta_dir, marker fns, host_conf_path)
2026-07-10 20:32:03 +02:00
lifecycle
refactor( #2285 ): inline remaining 1:1 path wrappers (meta_dir, marker fns, host_conf_path)
2026-07-10 20:32:03 +02:00
socket_server
fix( #2377 ): remove unused submit_init_config re-export from socket_server
2026-07-11 12:19:52 +02:00
stats
feat( #2289 ): debounced SweepHealth banner tracker, wire knowledge pull
2026-07-10 14:46:43 +02:00
stores
fix( #2164 ): domain-URL webhooks + HMAC + config-PR polling fallback
2026-07-11 23:28:16 +02:00
workers
fix( #2164 ): address argus review — Option<String> secret + stale hook cleanup
2026-07-12 02:21:33 +02:00
actions.rs
refactor( #2285 ): drop coordinator 1:1 path accessors, callers use paths:: directly
2026-07-10 20:32:03 +02:00
client.rs
hive-c0re: admin socket server + client (stub dispatch)
2026-05-14 20:49:11 +02:00
container_view.rs
refactor( #2285 ): repoint all hive-c0re host-path consumers to paths.rs
2026-07-10 20:32:03 +02:00
coordinator.rs
refactor( #2285 ): drop coordinator 1:1 path accessors, callers use paths:: directly
2026-07-10 20:32:03 +02:00
dashboard_events.rs
feat(hive-c0re): replace rebuild queue with generic job-DAG queue
2026-07-06 20:36:57 +02:00
flake_check.rs
refactor( #2111 ): remove nixpkgs-unstable, source claude-code from main nixpkgs
2026-07-01 19:32:46 +02:00
gateway_nginx.rs
refactor( #2285 ): inline remaining 1:1 path wrappers (meta_dir, marker fns, host_conf_path)
2026-07-10 20:32:03 +02:00
lib.rs
fix( #2164 ): domain-URL webhooks + HMAC + config-PR polling fallback
2026-07-11 23:28:16 +02:00
loose_ends.rs
style: import ordering + blank lines after now_unix sweep (treefmt)
2026-07-06 22:08:40 +02:00
main.rs
fix( #2164 ): address argus review — Option<String> secret + stale hook cleanup
2026-07-12 02:21:33 +02:00
matrix.rs
refactor( #2285 ): repoint all hive-c0re host-path consumers to paths.rs
2026-07-10 20:32:03 +02:00
meta.rs
feat( #1970 ): host services.hyperhive.github.enable (default true) + meta.rs propagation of the off-switch
2026-07-11 12:18:55 +02:00
migrate.rs
refactor( #2285 ): inline remaining 1:1 path wrappers (meta_dir, marker fns, host_conf_path)
2026-07-10 20:32:03 +02:00
paths.rs
fix( #2164 ): domain-URL webhooks + HMAC + config-PR polling fallback
2026-07-11 23:28:16 +02:00
priv_client.rs
docs( #1970 ): rewrite for UI-driven shape (github.enable + host switch), purge githubAccount refs, regen hivectl-cli.md
2026-07-11 12:18:55 +02:00
questions.rs
refactor: drop kind_to_str wrapper, call ApprovalKind::as_str directly
2026-07-06 21:49:46 +02:00
server.rs
fix( #2377 ): extract handle_agent_status — drop clippy::too_many_lines allow
2026-07-11 12:19:52 +02:00
webhook_secret.rs
fix( #2164 ): domain-URL webhooks + HMAC + config-PR polling fallback
2026-07-11 23:28:16 +02:00