From ffcba2b026f513575a8f52ba453ca3669a6920ac Mon Sep 17 00:00:00 2001 From: damocles Date: Sat, 21 Nov 2026 13:24:24 +0100 Subject: [PATCH] swarm-review-classifier: only an error result falls back to its subtype --- swarm-review-classifier/src/run.rs | 24 +++++++++++++++++------- 1 file changed, 17 insertions(+), 7 deletions(-) diff --git a/swarm-review-classifier/src/run.rs b/swarm-review-classifier/src/run.rs index 848acbd48..a377f8a07 100644 --- a/swarm-review-classifier/src/run.rs +++ b/swarm-review-classifier/src/run.rs @@ -448,15 +448,17 @@ impl Sink for ResultSink { if event["type"] != "result" { return; } - let text = match event["result"].as_str().filter(|t| !t.is_empty()) { - Some(text) => text, - None => event["subtype"].as_str().unwrap_or_default(), - } - .to_owned(); + let text = event["result"].as_str().unwrap_or_default(); let outcome = if event["is_error"].as_bool().unwrap_or(false) { - Err(format!("claude reported an error: {text}")) + // An error result with no text names its subtype instead. + let reported = if text.is_empty() { + event["subtype"].as_str().unwrap_or_default() + } else { + text + }; + Err(format!("claude reported an error: {reported}")) } else { - Ok(text) + Ok(text.to_owned()) }; *self .result @@ -586,6 +588,14 @@ mod tests { ); } + #[test] + fn an_empty_non_error_result_stays_empty_whatever_its_subtype() { + let sink = sink_after(&serde_json::json!({ + "type": "result", "is_error": false, "subtype": "success", + })); + assert_eq!(sink.take(), Ok(String::new())); + } + #[test] fn no_reported_error_leaves_the_exit_alone() { let ok = sink_after(&serde_json::json!({