swarm-ui: opening a dialog no longer scrolls the page to the top
This commit is contained in:
parent
44b248bf6d
commit
ff4e42f1ae
2 changed files with 21 additions and 1 deletions
|
|
@ -19,7 +19,9 @@
|
|||
`fit-content` sizing — `max-width` has the same carving-out
|
||||
requirement `width` did. */
|
||||
box-sizing: border-box;
|
||||
position: relative;
|
||||
/* No `position` here: a modal dialog is `position: fixed` by default, which
|
||||
also anchors the close button below. Setting `relative` put the dialog in
|
||||
the page's flow, and focusing it on open scrolled the page to the top. */
|
||||
width: fit-content;
|
||||
--ui-dialog-width: min(90vw, 64em);
|
||||
max-width: var(--ui-dialog-width);
|
||||
|
|
|
|||
18
frontend/packages/swarm-ui/test/dialog-css.test.mjs
Normal file
18
frontend/packages/swarm-ui/test/dialog-css.test.mjs
Normal file
|
|
@ -0,0 +1,18 @@
|
|||
// A modal `<dialog>` is `position: fixed` by default. Setting `position` on the
|
||||
// `.ui-dialog` rule puts it in the page's flow, and focusing it on open then
|
||||
// scrolls the page to the top. Run by `npm test`.
|
||||
import assert from "node:assert/strict";
|
||||
import { readFileSync } from "node:fs";
|
||||
import { test } from "node:test";
|
||||
|
||||
const css = readFileSync(
|
||||
new URL("../src/ui/dialog/Dialog.css", import.meta.url),
|
||||
"utf8",
|
||||
);
|
||||
|
||||
test("the dialog rule leaves its position to the browser", () => {
|
||||
const rule = css.match(/\.ui-dialog \{([^}]*)\}/);
|
||||
assert.ok(rule, "the .ui-dialog rule exists");
|
||||
const declarations = rule[1].replace(/\/\*[\s\S]*?\*\//g, "");
|
||||
assert.doesNotMatch(declarations, /(^|[\s;])position\s*:/);
|
||||
});
|
||||
Loading…
Reference in a new issue