Watch
0
0
Fork
You've already forked hyperhive
0

review-classifier: UI state wiring with no computation needs no test of its own

An ARIA attribute or pressed flag, a focus call after navigation and a badge
shown by an existing boolean are glue like the other UI wiring already listed.
Logic that decides from data keeps its test.
This commit is contained in:
argus 2026-11-19 19:52:29 +01:00 • committed by mara
commit cd64cbae82

View file

@ -52,8 +52,12 @@ classifications:
calling a function that is already tested. So does presentational calling a function that is already tested. So does presentational
layout math: a small helper in UI code that only maps a value to a layout math: a small helper in UI code that only maps a value to a
position, size or colour that CSS then draws, such as the place of a position, size or colour that CSS then draws, such as the place of a
slider's zone edge. A diff whose changed files slider's zone edge. So does UI state wiring with no computation
are all test code (a fixture under `nix/module-eval/`, behind it: an ARIA attribute or a pressed flag on an element, a focus
call after navigation, a badge shown or hidden by a boolean the page
already has. Logic that decides something from data, such as a
threshold, a filter or a parse, still needs its test. A diff whose
changed files are all test code (a fixture under `nix/module-eval/`,
`nix/checks.nix`, a crate's `tests/` directory, or Rust inside `nix/checks.nix`, a crate's `tests/` directory, or Rust inside
`#[cfg(test)]` or a `#[test]` function) changes no behaviour: the `#[cfg(test)]` or a `#[test]` function) changes no behaviour: the
question is not applicable. So is a diff that changes only question is not applicable. So is a diff that changes only