swarm ui: ask before actions that cannot be undone, with a danger button and a useConfirm hook
Button gains a danger variant and an autofocus prop; ConfirmDialog gains danger (red confirm, focus on cancel). Destroy, delete linked account, delete claude login, remove schedule and delete flow use it. New useConfirm hook asks from inside a handler (await confirm({...})) without a dialog's state at the call site. It now guards: removing a swarm-wide egress domain, removing a domain for every agent from an agent's popover, removing a stored API-key environment, firing a schedule now, moving an agent's internet to a looser mode, the /clear message, and reload over unsaved instructions (replacing window.confirm). The review try-out's button is now called push a branch for a PR, since it pushes a branch and does not open one, and asks first. loosensInternet is a tested helper.
This commit is contained in:
parent
d9551415bf
commit
c3e24fe2c6
6 changed files with 353 additions and 60 deletions
|
|
@ -50,6 +50,7 @@ import { Preformatted } from "../ui/preformatted/Preformatted.js";
|
|||
import { SectionHeading } from "../ui/section-heading/SectionHeading.js";
|
||||
import { Toolbar } from "../ui/toolbar/Toolbar.js";
|
||||
import { ConfirmDialog } from "../ui/confirm-dialog/ConfirmDialog.js";
|
||||
import { useConfirm } from "../ui/confirm-dialog/useConfirm.js";
|
||||
import { Popover } from "../ui/popover/Popover.js";
|
||||
import { Badge, type BadgeTone } from "@hive/shared/badge.js";
|
||||
import { GearIcon } from "@hive/shared/icons.js";
|
||||
|
|
@ -131,7 +132,7 @@ const SELECT_OPTIONS: SelectOption[] = [
|
|||
{ value: "beta", label: "beta" },
|
||||
];
|
||||
|
||||
const BUTTON_VARIANTS: ButtonVariant[] = ["primary", "default"];
|
||||
const BUTTON_VARIANTS: ButtonVariant[] = ["primary", "default", "danger"];
|
||||
const BADGE_TONES: BadgeTone[] = [
|
||||
"neutral",
|
||||
"positive",
|
||||
|
|
@ -396,10 +397,46 @@ function FilterableViewSample() {
|
|||
);
|
||||
}
|
||||
|
||||
function ConfirmDialogSample() {
|
||||
const [open, setOpen] = useState(false);
|
||||
// `useConfirm`: ask in the middle of a handler, without a dialog's state.
|
||||
function UseConfirmSample() {
|
||||
const [confirm, dialog] = useConfirm();
|
||||
const [answer, setAnswer] = useState("not asked yet");
|
||||
async function ask() {
|
||||
const yes = await confirm({
|
||||
label: "sample question",
|
||||
confirmLabel: "go ahead",
|
||||
body: <p>Awaited in the click handler: it resolves true or false.</p>,
|
||||
});
|
||||
setAnswer(yes ? "confirmed" : "cancelled");
|
||||
}
|
||||
return (
|
||||
<>
|
||||
<Button onClick={() => void ask()}>ask with useConfirm</Button>
|
||||
<span role="status"> answer: {answer}</span>
|
||||
{dialog}
|
||||
</>
|
||||
);
|
||||
}
|
||||
|
||||
function ConfirmDialogSample() {
|
||||
const [open, setOpen] = useState(false);
|
||||
const [dangerOpen, setDangerOpen] = useState(false);
|
||||
return (
|
||||
<>
|
||||
<Button onClick={() => setDangerOpen(true)}>open danger confirm</Button>
|
||||
<ConfirmDialog
|
||||
open={dangerOpen}
|
||||
label="sample danger confirm dialog"
|
||||
onCancel={() => setDangerOpen(false)}
|
||||
onConfirm={() => setDangerOpen(false)}
|
||||
confirmLabel="delete"
|
||||
danger
|
||||
>
|
||||
<p>
|
||||
<code>danger</code> makes the confirm button red and starts the focus
|
||||
on cancel, for an action that cannot be taken back.
|
||||
</p>
|
||||
</ConfirmDialog>
|
||||
<Button onClick={() => setOpen(true)}>open confirm dialog</Button>
|
||||
<ConfirmDialog
|
||||
open={open}
|
||||
|
|
@ -771,6 +808,9 @@ export function ComponentsPage() {
|
|||
<Sample label="modal, cancel/confirm button row">
|
||||
<ConfirmDialogSample />
|
||||
</Sample>
|
||||
<Sample label="useConfirm, awaited in a handler">
|
||||
<UseConfirmSample />
|
||||
</Sample>
|
||||
</Section>
|
||||
|
||||
<Section title="Badge (@hive/shared — used by swarm-ui and the per-agent page)">
|
||||
|
|
|
|||
|
|
@ -13,6 +13,7 @@ import { TextAreaField } from "../ui/text-area-field/TextAreaField.js";
|
|||
import { Button } from "../ui/button/Button.js";
|
||||
import { FormStack } from "../ui/form-stack/FormStack.js";
|
||||
import { FormResult } from "../ui/submit/FormResult.js";
|
||||
import { useConfirm } from "../ui/confirm-dialog/useConfirm.js";
|
||||
import { useSubmit } from "../ui/submit/useSubmit.js";
|
||||
|
||||
// A swarm-controller without the route answers 404 with no problem body.
|
||||
|
|
@ -31,6 +32,23 @@ export function LinkBackendEnvForm({
|
|||
const [env, setEnv] = useState("");
|
||||
// The success line is what the request did, so it is the done value.
|
||||
const { state, submitting: busy, run } = useSubmit<string>();
|
||||
const [confirm, confirmDialog] = useConfirm();
|
||||
|
||||
async function removeEnv() {
|
||||
const yes = await confirm({
|
||||
label: "remove the API-key environment",
|
||||
confirmLabel: "remove",
|
||||
danger: true,
|
||||
body: (
|
||||
<p>
|
||||
Remove the stored API-key environment for <strong>{agent}</strong>?
|
||||
The stored text cannot be read back, so it cannot be restored; paste
|
||||
it again to set it.
|
||||
</p>
|
||||
),
|
||||
});
|
||||
if (yes) send("DELETE", "removed the API-key environment for");
|
||||
}
|
||||
|
||||
function send(method: "PUT" | "DELETE", done: string) {
|
||||
void run(
|
||||
|
|
@ -89,11 +107,7 @@ export function LinkBackendEnvForm({
|
|||
<Button variant="primary" type="submit" disabled={busy}>
|
||||
{busy ? "saving…" : "save"}
|
||||
</Button>
|
||||
<Button
|
||||
type="button"
|
||||
disabled={busy}
|
||||
onClick={() => send("DELETE", "removed the API-key environment for")}
|
||||
>
|
||||
<Button type="button" disabled={busy} onClick={() => void removeEnv()}>
|
||||
remove
|
||||
</Button>
|
||||
</FormStack>
|
||||
|
|
@ -106,6 +120,7 @@ export function LinkBackendEnvForm({
|
|||
)}
|
||||
failed="failed to update the API-key environment"
|
||||
/>
|
||||
{confirmDialog}
|
||||
</Panel>
|
||||
);
|
||||
}
|
||||
|
|
|
|||
|
|
@ -416,6 +416,7 @@ export function FlowEditorPage({
|
|||
open={confirmDelete}
|
||||
label="delete this flow"
|
||||
confirmLabel="delete"
|
||||
danger
|
||||
onCancel={() => setConfirmDelete(false)}
|
||||
onConfirm={() => void onDelete()}
|
||||
>
|
||||
|
|
|
|||
|
|
@ -13,10 +13,10 @@
|
|||
// **load the repo's rules** fills the rows from the rules on the repo's default
|
||||
// branch (`GET /api/review-classifier/rules`), to run as they are or to edit.
|
||||
//
|
||||
// **open a PR** posts the rows to `POST /api/review-classifier/open-pr`, which
|
||||
// has the classifier's forge account push a branch adding them to the repo's
|
||||
// rules file, with the operator as commit author, and links to the forge's page
|
||||
// for opening the PR from that branch.
|
||||
// **push a branch for a PR** (asked first) posts the rows to
|
||||
// `POST /api/review-classifier/open-pr`, which has the classifier's forge account
|
||||
// push a branch adding them to the repo's rules file, with the operator as commit
|
||||
// author, and links to the forge's page for opening the PR from that branch.
|
||||
//
|
||||
// The inputs stay as typed after a run, so the operator can edit and run
|
||||
// again. The section keeps nothing you typed and no
|
||||
|
|
@ -29,6 +29,7 @@ import { ActionRow } from "../../ui/action-row/ActionRow.js";
|
|||
import { Button } from "../../ui/button/Button.js";
|
||||
import { FieldGrid } from "../../ui/field-grid/FieldGrid.js";
|
||||
import { ConfirmDialog } from "../../ui/confirm-dialog/ConfirmDialog.js";
|
||||
import { useConfirm } from "../../ui/confirm-dialog/useConfirm.js";
|
||||
import { Disclosure } from "../../ui/disclosure/Disclosure.js";
|
||||
import { ExternalLink } from "../../ui/external-link/ExternalLink.js";
|
||||
import { Panel } from "../../ui/panel/Panel.js";
|
||||
|
|
@ -79,6 +80,7 @@ function blankDraft(): ClassificationDraft {
|
|||
|
||||
export function ReviewTryOut() {
|
||||
const [repo, setRepo] = useState("");
|
||||
const [ask, askDialog] = useConfirm();
|
||||
const [pr, setPr] = useState("");
|
||||
const [drafts, setDrafts] = useState<ClassificationDraft[]>(() => [
|
||||
blankDraft(),
|
||||
|
|
@ -303,6 +305,23 @@ export function ReviewTryOut() {
|
|||
}
|
||||
}
|
||||
|
||||
// Pushing a branch to a forge repo is not undone from here, so it is asked.
|
||||
async function askPushBranch() {
|
||||
const rows = drafts.length;
|
||||
const yes = await ask({
|
||||
label: "push a branch for a PR",
|
||||
confirmLabel: "push the branch",
|
||||
body: (
|
||||
<p>
|
||||
Push a new branch to <strong>{repo.trim()}</strong> with{" "}
|
||||
{rows === 1 ? "this classification" : `these ${rows} classifications`}
|
||||
, as you? It does not open the PR; the link to open it follows.
|
||||
</p>
|
||||
),
|
||||
});
|
||||
if (yes) void openPr();
|
||||
}
|
||||
|
||||
// Pushes the rows on a new branch of the repo and keeps the link to open
|
||||
// the PR from it.
|
||||
async function openPr() {
|
||||
|
|
@ -354,8 +373,8 @@ export function ReviewTryOut() {
|
|||
Run a review classification against a real PR and see how the model
|
||||
answers it. A run posts nothing to the forge and changes no rules, but
|
||||
it does appear under recent runs: change the classification and run it
|
||||
again until it answers the way you want. Then open a PR to add it to
|
||||
the repo's rules.
|
||||
again until it answers the way you want. Then push a branch for a PR
|
||||
to add it to the repo's rules.
|
||||
</p>
|
||||
<form class="ui-tryout-form" onSubmit={(e) => void run(e)}>
|
||||
<FieldGrid class="ui-tryout-target">
|
||||
|
|
@ -441,11 +460,11 @@ export function ReviewTryOut() {
|
|||
{running ? "running…" : "run"}
|
||||
</Button>
|
||||
<Button
|
||||
onClick={() => void openPr()}
|
||||
onClick={() => void askPushBranch()}
|
||||
disabled={opening || openPrProblem !== null}
|
||||
describedBy={openPrProblem !== null ? HINT_ID : undefined}
|
||||
>
|
||||
{opening ? "pushing…" : "open a PR"}
|
||||
{opening ? "pushing…" : "push a branch for a PR"}
|
||||
</Button>
|
||||
</ActionRow>
|
||||
{capProblem !== null ? (
|
||||
|
|
@ -476,6 +495,7 @@ export function ReviewTryOut() {
|
|||
) : null}
|
||||
</form>
|
||||
</Disclosure>
|
||||
{askDialog}
|
||||
<ConfirmDialog
|
||||
open={confirmLoad}
|
||||
label="replace the classifications"
|
||||
|
|
|
|||
|
|
@ -14,6 +14,7 @@ import { ApiErrorPanel } from "@hive/shared/api-error-panel.js";
|
|||
import { readApiError, type ProblemDetails } from "@hive/shared/api-error.js";
|
||||
import { Button } from "../../ui/button/Button.js";
|
||||
import { ConfirmDialog } from "../../ui/confirm-dialog/ConfirmDialog.js";
|
||||
import { useConfirm } from "../../ui/confirm-dialog/useConfirm.js";
|
||||
import { FilterableView } from "../../ui/filterable-view/FilterableView.js";
|
||||
import { Toolbar } from "../../ui/toolbar/Toolbar.js";
|
||||
import { LazyDisclosure } from "../../ui/disclosure/LazyDisclosure.js";
|
||||
|
|
@ -89,6 +90,7 @@ function SchedulesBody() {
|
|||
const [creating, setCreating] = useState(false);
|
||||
const [pendingIds, setPendingIds] = useState<Set<string>>(new Set());
|
||||
const [removeTarget, setRemoveTarget] = useState<Schedule | null>(null);
|
||||
const [confirm, fireDialog] = useConfirm();
|
||||
const [actionError, setActionError] = useState<ProblemDetails | null>(null);
|
||||
|
||||
function markPending(id: string, on: boolean) {
|
||||
|
|
@ -120,7 +122,20 @@ function SchedulesBody() {
|
|||
}
|
||||
}
|
||||
|
||||
function fireNow(s: Schedule) {
|
||||
async function fireNow(s: Schedule) {
|
||||
const repeats = s.interval_seconds !== null;
|
||||
const yes = await confirm({
|
||||
label: "fire schedule now",
|
||||
confirmLabel: "fire now",
|
||||
body: (
|
||||
<p>
|
||||
Fire <strong>{s.name}</strong> now? It sends its message to{" "}
|
||||
{s.agents.join(", ")} at once, and its start moves to this moment
|
||||
{repeats ? ", so it repeats from now on" : ""}. That cannot be undone.
|
||||
</p>
|
||||
),
|
||||
});
|
||||
if (!yes) return;
|
||||
return act(s.id, () =>
|
||||
fetch(`/api/schedules/${encodeURIComponent(s.id)}`, {
|
||||
method: "PATCH",
|
||||
|
|
@ -232,10 +247,12 @@ function SchedulesBody() {
|
|||
}
|
||||
/>
|
||||
) : null}
|
||||
{fireDialog}
|
||||
<ConfirmDialog
|
||||
open={removeTarget !== null}
|
||||
label="remove schedule"
|
||||
confirmLabel="remove"
|
||||
danger
|
||||
onCancel={() => setRemoveTarget(null)}
|
||||
onConfirm={confirmRemove}
|
||||
>
|
||||
|
|
|
|||
|
|
@ -22,6 +22,7 @@ import {
|
|||
useDeniedDomains,
|
||||
} from "../../agent/detail/useAllowedDomains.js";
|
||||
import { Button } from "../../ui/button/Button.js";
|
||||
import { useConfirm } from "../../ui/confirm-dialog/useConfirm.js";
|
||||
import { LazyDisclosure } from "../../ui/disclosure/LazyDisclosure.js";
|
||||
import { Dialog } from "../../ui/dialog/Dialog.js";
|
||||
import { Hint } from "../../ui/hint/Hint.js";
|
||||
|
|
@ -46,6 +47,27 @@ function DomainSection({
|
|||
}) {
|
||||
const { entries, behind, error, busy, remove, refetch } = list;
|
||||
const [adding, setAdding] = useState(false);
|
||||
const [confirm, confirmDialog] = useConfirm();
|
||||
|
||||
async function removeEntry(e: Parameters<typeof remove>[0]) {
|
||||
const verb = kind === "deny" ? "Stop denying" : "Stop allowing";
|
||||
if (
|
||||
!(await confirm({
|
||||
label: `${verb.toLowerCase()} ${e.domain} swarm-wide`,
|
||||
confirmLabel: "remove",
|
||||
danger: true,
|
||||
body: (
|
||||
<p>
|
||||
{verb} <code>{e.domain}</code> for <strong>every agent</strong> on
|
||||
the swarm?
|
||||
</p>
|
||||
),
|
||||
}))
|
||||
) {
|
||||
return;
|
||||
}
|
||||
void remove(e);
|
||||
}
|
||||
|
||||
// A list already loaded stays under a failed refetch, so a change that
|
||||
// worked is not hidden by a read that did not.
|
||||
|
|
@ -94,7 +116,7 @@ function DomainSection({
|
|||
<Button
|
||||
disabled={busy}
|
||||
ariaLabel={`remove ${e.domain}`}
|
||||
onClick={() => void remove(e)}
|
||||
onClick={() => void removeEntry(e)}
|
||||
>
|
||||
remove
|
||||
</Button>
|
||||
|
|
@ -121,6 +143,7 @@ function DomainSection({
|
|||
/>
|
||||
) : null}
|
||||
</Dialog>
|
||||
{confirmDialog}
|
||||
</>
|
||||
)}
|
||||
</section>
|
||||
|
|
|
|||
Loading…
Reference in a new issue