review try-out: show why the open-PR button is disabled
The form's one hint put the PR number first, so with the PR field empty (which opening a PR doesn't need) it hid the repo or row problem that was actually disabling the open-PR button. runProblem now checks the rows first and the PR number last, and is tested. Refs #5259
This commit is contained in:
parent
c90bd705a7
commit
be2e64fa89
1 changed files with 28 additions and 3 deletions
|
|
@ -41,6 +41,7 @@ import {
|
|||
prNumber,
|
||||
repoProblem,
|
||||
rowsProblem,
|
||||
runProblem,
|
||||
toBody,
|
||||
type ClassificationDraft,
|
||||
type OpenPrAnswer,
|
||||
|
|
@ -218,9 +219,7 @@ export function ReviewTryOutPage() {
|
|||
}, [runId]);
|
||||
|
||||
const openPrProblem = rowsProblem(repo, drafts);
|
||||
const problem =
|
||||
(prNumber(pr) === null ? "a PR number is a whole number above 0" : null) ??
|
||||
openPrProblem;
|
||||
const problem = runProblem(repo, pr, drafts);
|
||||
|
||||
async function run(e: Event) {
|
||||
e.preventDefault();
|
||||
|
|
|
|||
Loading…
Reference in a new issue