mara/hyperhive
mara/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

swarm ui: a diff column on the pull requests card, and "approved" as its header

Browse source 
The pull requests card gets a diff column, the lines a PR adds and removes
(`+120 −8`), sortable on the total. The controller takes the counts from the
forge's pull request list, so no call is added. The column that said "has all
approvals" is now headed "approved".
This commit is contained in:
iris 2026-11-07 10:46:02 +01:00 • committed by mara
commit 944fd5b726
1 changed files with 46 additions and 3 deletions
Download patch file Download diff file Expand all files Collapse all files

11
frontend/packages/swarm-ui/test/pr-report.test.mjs
View file

@ -3,6 +3,8 @@ import assert from "node:assert/strict";
import { test } from "node:test";
import {
approvalsText,
diffSize,
diffText,
hasAllApprovals,
prReportUrl,
yesNo,
@ -52,6 +54,15 @@ test("an unprotected base, or a rule asking for none, shows only what it has", (
);
});
test("the diff reads as lines added and removed, and sorts on both", () => {
assert.equal(diffText({ additions: 120, deletions: 8 }), "+120 −8");
assert.equal(diffText({ additions: 0, deletions: 3 }), "+0 −3");
assert.equal(diffText({ additions: 5, deletions: null }), "+5 −0");
assert.equal(diffText({ additions: null, deletions: null }), "—");
assert.equal(diffSize({ additions: 120, deletions: 8 }), 128);
assert.equal(diffSize({ additions: null, deletions: null }), 0);
});
test("a PR has all approvals when it meets the rule, and an unprotected base always does", () => {
assert.equal(hasAllApprovals(row({})), false);
assert.equal(hasAllApprovals(row({ approvals: 2 })), true);