frontend: one dismiss rule for menus and popovers, menu keys, and dialog and side panel focus
useDismiss (shared) closes a floating box on a press outside or Escape: the press is seen in the capture phase, a press in an open modal dialog is not outside, Escape yields to a modal dialog the box is not in, and a box in a dialog closes alone. Popover, Dropdown, SettingsMenu, LinksMenu and UserMenu use it in place of five copies with different rules; Escape returns the focus to the button. Dropdown takes the focus on open and moves with the arrow keys, Home and End. The link, account and settings popovers drop role=menu (they had no menu keys) for a labelled group. Dialog no longer reports a close the caller asked for, ignores a drag that started inside and ended on the backdrop, and has a 2.75em close button. Popover uses the shared clampLeft. The dashboard's side panel is inert while closed, takes the focus on open and gives it back, and no longer claims aria-modal; hive-dialog gives the focus back on close.
This commit is contained in:
parent
a19745d30d
commit
844fb0a219
1 changed files with 299 additions and 121 deletions
43
frontend/packages/swarm-ui/test/use-dismiss.test.mjs
Normal file
43
frontend/packages/swarm-ui/test/use-dismiss.test.mjs
Normal file
|
|
@ -0,0 +1,43 @@
|
|||
// When a press or Escape closes a floating box: the rule `useDismiss` applies.
|
||||
// Run by `npm test`.
|
||||
import assert from "node:assert/strict";
|
||||
import { test } from "node:test";
|
||||
import {
|
||||
dialogsOverBox,
|
||||
escapeDismisses,
|
||||
pointerDismisses,
|
||||
} from "../../shared/src/use-dismiss.ts";
|
||||
|
||||
test("a press outside the box and every dialog closes it", () => {
|
||||
assert.equal(pointerDismisses(false, false), true);
|
||||
});
|
||||
|
||||
test("a press inside the box, or in a dialog over it, does not", () => {
|
||||
assert.equal(pointerDismisses(true, false), false);
|
||||
assert.equal(pointerDismisses(false, true), false);
|
||||
assert.equal(pointerDismisses(true, true), false);
|
||||
});
|
||||
|
||||
test("Escape closes the box unless a dialog it is not in is open", () => {
|
||||
assert.equal(escapeDismisses(false), true);
|
||||
assert.equal(escapeDismisses(true), false);
|
||||
});
|
||||
|
||||
test("a dialog the box is in is not over it", () => {
|
||||
const holding = { holdsBox: true };
|
||||
const over = { holdsBox: false };
|
||||
assert.deepEqual(
|
||||
dialogsOverBox([holding, over], (d) => d.holdsBox),
|
||||
[over],
|
||||
);
|
||||
assert.deepEqual(
|
||||
dialogsOverBox([holding], (d) => d.holdsBox),
|
||||
[],
|
||||
);
|
||||
});
|
||||
|
||||
test("a press in the dialog the box is in dismisses it", () => {
|
||||
const holding = { holdsBox: true };
|
||||
const over = dialogsOverBox([holding], (d) => d.holdsBox);
|
||||
assert.equal(pointerDismisses(false, over.includes(holding)), true);
|
||||
});
|
||||
Loading…
Reference in a new issue