Watch
0
0
Fork
You've already forked hyperhive
0

frontend: one dismiss rule for menus and popovers, menu keys, and dialog and side panel focus

useDismiss (shared) closes a floating box on a press outside or Escape: the press is seen in the capture phase, a press in an open modal dialog is not outside, Escape yields to a modal dialog the box is not in, and a box in a dialog closes alone. Popover, Dropdown, SettingsMenu, LinksMenu and UserMenu use it in place of five copies with different rules; Escape returns the focus to the button. Dropdown takes the focus on open and moves with the arrow keys, Home and End. The link, account and settings popovers drop role=menu (they had no menu keys) for a labelled group. Dialog no longer reports a close the caller asked for, ignores a drag that started inside and ended on the backdrop, and has a 2.75em close button. Popover uses the shared clampLeft. The dashboard's side panel is inert while closed, takes the focus on open and gives it back, and no longer claims aria-modal; hive-dialog gives the focus back on close.
This commit is contained in:
iris 2026-11-19 18:54:04 +01:00 • committed by mara
commit 844fb0a219

View file

@ -31,6 +31,8 @@ class HiveDialog extends HTMLElement {
} = this._opts || {};
const root = attachShadowCss(this, dialogCss);
// The control that had the focus, so it gets it back when this closes.
const opener = document.activeElement;
let settled = false;
const done = (value) => {
@ -41,6 +43,7 @@ class HiveDialog extends HTMLElement {
new CustomEvent("hive-dialog-close", { detail: value }),
);
this.remove();
if (opener instanceof HTMLElement && opener.isConnected) opener.focus();
};
const onKey = (e) => {
if (dismissable && e.key === "Escape") {