mara/hyperhive
mara/hyperhive
Watch
0
0
Fork
You've already forked hyperhive
 0
Code Activity

swarm ui: the PR report's approvals column filters on whether the rule is met

Browse source 
The report had an approvals column (1/2) and a separate approved column.
They are one fact, so approvals now carries the filter, complete or missing,
and the approved column is gone.
This commit is contained in:
iris 2026-11-09 22:44:10 +01:00
commit 71a4d1d255
1 changed files with 27 additions and 12 deletions
Download patch file Download diff file Expand all files Collapse all files

6
docs/2-handbook/swarm/ui.md
View file

@ -607,9 +607,9 @@ and base branch, and what a reviewer or merger filters on:
rule asks for (`1/2`). An approval counts when it stands as the reviewer's latest
decision, on the PR's current head, neither stale nor dismissed, and from a
reviewer whose approval the rule accepts. A reviewer whose latest review asks for changes shows **changes
requested**.
- **approved**: the approvals meet the rule. A PR into a branch with no
protection rule has nothing to approve, so it counts as approved.
requested**. Filter the column to **complete** for the PRs whose approvals meet
the rule, or **missing** for the rest. A PR into a branch with no protection
rule has nothing to approve, so it counts as complete.
- **diff**: the lines the PR adds and removes (`+120 −8`), as the forge counts them.
- **conflicts**: the forge can't merge the PR as it stands.
- **protected base**: the base branch has a protection rule. A stacked PR targets a