Watch
0
0
Fork
You've already forked hyperhive
0

review-classifier: skip draft prs, classify once when they leave draft

This commit is contained in:
atlas 2026-11-02 17:58:22 +01:00 • committed by mara
commit 49ef93a19e

View file

@ -91,6 +91,8 @@ mod tests {
sender: "mara".to_owned(),
is_pull: false,
assignees: assignees.iter().map(|a| (*a).to_owned()).collect(),
draft: false,
undrafted: false,
}
}
@ -241,6 +243,29 @@ mod tests {
assert!(r.requests.is_empty());
}
/// A push to a draft PR requests nothing; the title edit that takes it out
/// of draft requests once.
#[test]
fn a_draft_gets_no_request_until_it_leaves_draft() {
let flows = builtins();
let before = Snapshot::default();
let draft = Delivery {
is_pull: true,
draft: true,
..delivery("synchronized", &[])
};
let r = route("pull_request_sync", &draft, &before, &flows, |_| false);
assert!(r.requests.is_empty());
let ready = Delivery {
is_pull: true,
undrafted: true,
..delivery("edited", &[])
};
let r = route("pull_request", &ready, &before, &flows, |_| false);
assert_eq!(r.requests.len(), 1);
assert_eq!(r.requests[0].node, "request-undrafted");
}
#[test]
fn an_event_no_flow_matches_changes_nothing() {
let before = Snapshot {