tests for the ci metrics, builder and hive forge accounts
This commit is contained in:
parent
c1234973be
commit
3032f34269
1 changed files with 493 additions and 1 deletions
|
|
@ -494,4 +494,273 @@ mod tests {
|
|||
assert_eq!(body["max_repo_creation"], 0);
|
||||
assert_eq!(body["allow_create_organization"], false);
|
||||
}
|
||||
|
||||
// The forge side, against a stand-in forge that answers by path.
|
||||
use super::super::tests::{Seen as Requests, routed_forge, sent, writes};
|
||||
use serde_json::{Value, json};
|
||||
use std::sync::atomic::{AtomicUsize, Ordering};
|
||||
|
||||
fn team_json(id: i64, permission: &str, units: &[&str]) -> Value {
|
||||
json!({
|
||||
"id": id,
|
||||
"name": TEAM,
|
||||
"description": TEAM_DESCRIPTION,
|
||||
"permission": permission,
|
||||
"includes_all_repositories": true,
|
||||
"can_create_org_repo": false,
|
||||
"units": units,
|
||||
})
|
||||
}
|
||||
|
||||
/// A forge listing `orgs` and giving each the teams in `teams`, every
|
||||
/// request not named by `rest` a 201 for a POST and 200 otherwise.
|
||||
async fn forge_of(
|
||||
orgs: &[&str],
|
||||
teams: Vec<(&'static str, u16, Value)>,
|
||||
rest: Vec<(String, u16, Value)>,
|
||||
) -> (Client, Requests) {
|
||||
let orgs: Vec<Value> = orgs.iter().map(|o| json!({"username": o})).collect();
|
||||
let teams: Vec<(String, u16, Value)> = teams
|
||||
.into_iter()
|
||||
.map(|(k, s, b)| (k.to_owned(), s, b))
|
||||
.collect();
|
||||
routed_forge(move |method, path, _| {
|
||||
let key = format!("{method} {path}");
|
||||
if key == "GET /api/v1/admin/orgs" {
|
||||
return (200, json!(orgs).to_string());
|
||||
}
|
||||
if let Some((_, s, b)) = teams.iter().chain(rest.iter()).find(|(k, _, _)| *k == key) {
|
||||
return (*s, b.to_string());
|
||||
}
|
||||
match method {
|
||||
"GET" => (404, r#"{"message":"no"}"#.to_owned()),
|
||||
"POST" => (201, "{}".to_owned()),
|
||||
_ => (200, "{}".to_owned()),
|
||||
}
|
||||
})
|
||||
.await
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn the_account_is_created_and_locked_out_of_creating_repos() {
|
||||
let (client, seen) = forge_of(
|
||||
&[],
|
||||
vec![],
|
||||
vec![at(
|
||||
"GET /api/v1/users/ci-metrics",
|
||||
200,
|
||||
json!({"email": EMAIL}),
|
||||
)],
|
||||
)
|
||||
.await;
|
||||
client.ensure_ci_metrics_user().await.unwrap();
|
||||
assert_eq!(
|
||||
writes(&seen),
|
||||
[
|
||||
"POST /api/v1/admin/users".to_owned(),
|
||||
"PATCH /api/v1/admin/users/ci-metrics".to_owned()
|
||||
]
|
||||
);
|
||||
let lock = sent(&seen, "PATCH", "/api/v1/admin/users/ci-metrics").unwrap();
|
||||
assert_eq!(lock["max_repo_creation"], 0);
|
||||
assert_eq!(lock["allow_create_organization"], false);
|
||||
assert_eq!(lock["login_name"], LOGIN);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn a_refused_create_stops_before_the_account_is_read_or_locked() {
|
||||
let (client, seen) = forge_of(
|
||||
&[],
|
||||
vec![],
|
||||
vec![
|
||||
at("POST /api/v1/admin/users", 500, json!({"message": "x"})),
|
||||
at("GET /api/v1/users/ci-metrics", 200, json!({"email": EMAIL})),
|
||||
],
|
||||
)
|
||||
.await;
|
||||
client.ensure_ci_metrics_user().await.expect_err("refused");
|
||||
assert_eq!(writes(&seen), ["POST /api/v1/admin/users"]);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn a_team_that_matches_is_left_and_one_with_the_wrong_grant_is_put_back() {
|
||||
let path = "GET /api/v1/orgs/o/teams";
|
||||
let (client, seen) = forge_of(
|
||||
&[],
|
||||
vec![(path, 200, json!([team_json(3, "read", &TEAM_UNITS)]))],
|
||||
vec![],
|
||||
)
|
||||
.await;
|
||||
assert_eq!(client.ensure_ci_metrics_team("o").await.unwrap(), 3);
|
||||
assert!(writes(&seen).is_empty());
|
||||
|
||||
let wide = team_json(3, "write", &["repo.actions", "repo.code"]);
|
||||
let (client, seen) = forge_of(&[], vec![(path, 200, json!([wide]))], vec![]).await;
|
||||
assert_eq!(client.ensure_ci_metrics_team("o").await.unwrap(), 3);
|
||||
assert_eq!(writes(&seen), ["PATCH /api/v1/teams/3"]);
|
||||
let edit = sent(&seen, "PATCH", "/api/v1/teams/3").unwrap();
|
||||
assert_eq!(edit["permission"], "read");
|
||||
assert_eq!(edit["units"], json!(TEAM_UNITS));
|
||||
assert_eq!(edit["includes_all_repositories"], true);
|
||||
assert_eq!(edit["can_create_org_repo"], false);
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn a_missing_team_is_created_read_only_on_actions_and_a_missing_id_fails() {
|
||||
let list = ("GET /api/v1/orgs/o/teams", 200, json!([]));
|
||||
let (client, seen) = forge_of(
|
||||
&[],
|
||||
vec![list.clone()],
|
||||
vec![at("POST /api/v1/orgs/o/teams", 201, json!({"id": 11}))],
|
||||
)
|
||||
.await;
|
||||
assert_eq!(client.ensure_ci_metrics_team("o").await.unwrap(), 11);
|
||||
let team = sent(&seen, "POST", "/api/v1/orgs/o/teams").unwrap();
|
||||
assert_eq!(team["name"], TEAM);
|
||||
assert_eq!(team["permission"], "read");
|
||||
assert_eq!(team["units"], json!(TEAM_UNITS));
|
||||
assert_eq!(team["includes_all_repositories"], true);
|
||||
assert_eq!(team["can_create_org_repo"], false);
|
||||
|
||||
let (client, _) = forge_of(&[], vec![list], vec![]).await;
|
||||
client
|
||||
.ensure_ci_metrics_team("o")
|
||||
.await
|
||||
.expect_err("created, but no id came back");
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn an_unreadable_team_list_is_an_error_and_never_a_create() {
|
||||
let (client, seen) = forge_of(
|
||||
&[],
|
||||
vec![("GET /api/v1/orgs/o/teams", 500, json!({"message": "x"}))],
|
||||
vec![],
|
||||
)
|
||||
.await;
|
||||
client
|
||||
.ensure_ci_metrics_team("o")
|
||||
.await
|
||||
.expect_err("unknown");
|
||||
assert!(writes(&seen).is_empty());
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn a_duplicate_create_is_found_by_a_re_read_and_a_refusal_with_no_team_fails() {
|
||||
let reads = Arc::new(AtomicUsize::new(0));
|
||||
let counted = Arc::clone(&reads);
|
||||
let (client, _) = routed_forge(move |method, path, _| match (method, path) {
|
||||
("GET", "/api/v1/orgs/o/teams") if counted.fetch_add(1, Ordering::SeqCst) == 0 => {
|
||||
(200, "[]".to_owned())
|
||||
}
|
||||
("GET", "/api/v1/orgs/o/teams") => {
|
||||
(200, json!([team_json(4, "read", &TEAM_UNITS)]).to_string())
|
||||
}
|
||||
("POST", _) => (409, r#"{"message":"exists"}"#.to_owned()),
|
||||
_ => (200, "{}".to_owned()),
|
||||
})
|
||||
.await;
|
||||
assert_eq!(client.ensure_ci_metrics_team("o").await.unwrap(), 4);
|
||||
|
||||
let (client, _) = forge_of(
|
||||
&[],
|
||||
vec![("GET /api/v1/orgs/o/teams", 200, json!([]))],
|
||||
vec![at(
|
||||
"POST /api/v1/orgs/o/teams",
|
||||
409,
|
||||
json!({"message": "x"}),
|
||||
)],
|
||||
)
|
||||
.await;
|
||||
client
|
||||
.ensure_ci_metrics_team("o")
|
||||
.await
|
||||
.expect_err("not found again");
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn every_page_of_organisations_is_read() {
|
||||
let asked = Arc::new(AtomicUsize::new(0));
|
||||
let counted = Arc::clone(&asked);
|
||||
let (client, _) = routed_forge(move |_, path, _| {
|
||||
assert_eq!(path, "/api/v1/admin/orgs");
|
||||
let page = counted.fetch_add(1, Ordering::SeqCst);
|
||||
let n = if page == 0 { ORG_PAGE as usize } else { 1 };
|
||||
let orgs: Vec<Value> = (0..n)
|
||||
.map(|i| json!({"username": format!("org-{page}-{i}")}))
|
||||
.collect();
|
||||
(200, json!(orgs).to_string())
|
||||
})
|
||||
.await;
|
||||
let names = client.all_orgs().await.unwrap();
|
||||
assert_eq!(names.len(), ORG_PAGE as usize + 1);
|
||||
assert_eq!(asked.load(Ordering::SeqCst), 2);
|
||||
assert_eq!(names.last().unwrap(), "org-1-0");
|
||||
}
|
||||
|
||||
fn at(key: &str, status: u16, body: Value) -> (String, u16, Value) {
|
||||
(key.to_owned(), status, body)
|
||||
}
|
||||
|
||||
fn member(id: i64) -> (String, u16, Value) {
|
||||
at(
|
||||
&format!("GET /api/v1/teams/{id}/members/ci-metrics"),
|
||||
200,
|
||||
json!({}),
|
||||
)
|
||||
}
|
||||
|
||||
#[tokio::test]
|
||||
async fn the_grants_are_complete_only_when_every_org_has_the_team_with_the_account_in_it() {
|
||||
let teams = |ok: bool| {
|
||||
vec![
|
||||
(
|
||||
"GET /api/v1/orgs/a/teams",
|
||||
200,
|
||||
json!([team_json(1, "read", &TEAM_UNITS)]),
|
||||
),
|
||||
(
|
||||
"GET /api/v1/orgs/b/teams",
|
||||
200,
|
||||
if ok {
|
||||
json!([team_json(2, "read", &TEAM_UNITS)])
|
||||
} else {
|
||||
json!([])
|
||||
},
|
||||
),
|
||||
]
|
||||
};
|
||||
let members = vec![member(1), member(2)];
|
||||
let (client, _) = forge_of(&["a", "b"], teams(true), members.clone()).await;
|
||||
assert_eq!(client.observe_ci_metrics_grants().await, Some(true));
|
||||
|
||||
// A team missing in one org.
|
||||
let (client, _) = forge_of(&["a", "b"], teams(false), members.clone()).await;
|
||||
assert_eq!(client.observe_ci_metrics_grants().await, Some(false));
|
||||
|
||||
// The account missing from a team (404), against a failed read (500).
|
||||
let (client, _) = forge_of(&["a", "b"], teams(true), vec![member(1)]).await;
|
||||
assert_eq!(client.observe_ci_metrics_grants().await, Some(false));
|
||||
let (client, _) = forge_of(
|
||||
&["a", "b"],
|
||||
teams(true),
|
||||
vec![
|
||||
member(1),
|
||||
at(
|
||||
"GET /api/v1/teams/2/members/ci-metrics",
|
||||
500,
|
||||
json!({"message": "x"}),
|
||||
),
|
||||
],
|
||||
)
|
||||
.await;
|
||||
assert_eq!(client.observe_ci_metrics_grants().await, None);
|
||||
|
||||
// An unreadable team list, and an unreadable org list.
|
||||
let mut unreadable = teams(true);
|
||||
unreadable[1] = ("GET /api/v1/orgs/b/teams", 500, json!({"message": "x"}));
|
||||
let (client, _) = forge_of(&["a", "b"], unreadable, members).await;
|
||||
assert_eq!(client.observe_ci_metrics_grants().await, None);
|
||||
let (client, _) = routed_forge(|_, _, _| (500, r#"{"message":"x"}"#.to_owned())).await;
|
||||
assert_eq!(client.observe_ci_metrics_grants().await, None);
|
||||
}
|
||||
}
|
||||
|
|
|
|||
Loading…
Reference in a new issue